Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 833103004: Update Android FreeType version. (Closed)

Created:
5 years, 11 months ago by bungeman-skia
Modified:
5 years, 1 month ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update Android FreeType version. Update FreeType to a newer version. Because this caused issues in finding the correct ftoptions.h and ftmodule.h [1], be sure to state the ones we want explicitly. This also add gzip.c which is needed for WOFF support [2]. [1] FreeType "Simplify header file hierarchy." fae382076409db198dfbff36ac4cbb97b05b30a1 [2] FreeType "[gzip] New function `FT_Gzip_Uncompress'." dc240524ff31891a442225430b28e9620c1fa89f Committed: https://skia.googlesource.com/skia/+/13dd023882d675cf0f728a8037858a05858397b8

Patch Set 1 #

Patch Set 2 : Add ftgzip (now required by sfnt). #

Patch Set 3 : Update #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -904 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gyp/freetype.gyp View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M gyp/freetype.gypi View 1 2 3 chunks +6 lines, -1 line 2 comments Download
A + third_party/freetype/include/freetype-android/ftmodule.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/freetype/include/freetype-android/ftoption.h View 1 2 13 chunks +96 lines, -25 lines 0 comments Download
D third_party/freetype/include_overrides/freetype/config/ftmodule.h View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/freetype/include_overrides/freetype/config/ftoption.h View 1 2 1 chunk +0 lines, -833 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
bungeman-skia
This works at PS2, but the change in FreeType is obviously subtly changing a large ...
5 years, 11 months ago (2015-01-13 19:48:46 UTC) #2
bungeman-skia
Now that we can see what's going to change again, let's update our version of ...
5 years, 1 month ago (2015-10-26 19:59:08 UTC) #3
djsollen
This updates us to the most recent commit into freetype, but the commit description implies ...
5 years, 1 month ago (2015-10-27 13:00:00 UTC) #4
bungeman-skia
Chrome for Android is currently on 2.6.1+1 and will need to be updated again soon. ...
5 years, 1 month ago (2015-10-27 14:21:44 UTC) #5
djsollen
lgtm. Can you file a buganizer bug against Android to track updating their copy of ...
5 years, 1 month ago (2015-10-27 14:31:14 UTC) #6
bungeman-skia
On 2015/10/27 14:31:14, djsollen wrote: > lgtm. Can you file a buganizer bug against Android ...
5 years, 1 month ago (2015-10-27 14:41:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833103004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/833103004/40001
5 years, 1 month ago (2015-10-27 15:28:29 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 15:39:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/13dd023882d675cf0f728a8037858a05858397b8

Powered by Google App Engine
This is Rietveld 408576698