Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 832943002: Don't set suggestion type to SEARCH_SUGGEST_ANSWER on search responses with Answers attached (Closed)

Created:
5 years, 11 months ago by dschuyler
Modified:
5 years, 11 months ago
Reviewers:
Mark P, Justin Donnelly
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't set suggestion type to SEARCH_SUGGEST_ANSWER on search responses with Answers attached. This type is no longer used in the UI code, since answers can be attached to suggestions of any type. BUG= Committed: https://crrev.com/8b3e5086a8625760545c976d2a0156106946bb0c Cr-Commit-Position: refs/heads/master@{#311912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M components/omnibox/search_suggestion_parser.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
dschuyler
Hi Justin, I think this is the change requested to AutocompleteMatchType::SEARCH_SUGGEST_ANSWER. i.e. changing only that ...
5 years, 11 months ago (2015-01-05 19:26:10 UTC) #2
Justin Donnelly
On 2015/01/05 19:26:10, dschuyler wrote: > Hi Justin, > > I think this is the ...
5 years, 11 months ago (2015-01-05 20:04:30 UTC) #3
dschuyler
5 years, 11 months ago (2015-01-06 02:24:23 UTC) #5
Mark P
lgtm
5 years, 11 months ago (2015-01-06 23:25:40 UTC) #6
Justin Donnelly
On 2015/01/06 23:25:40, Mark P wrote: > lgtm FYI, rather than mucking with this logic ...
5 years, 11 months ago (2015-01-07 21:52:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832943002/1
5 years, 11 months ago (2015-01-16 16:25:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 16:51:24 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 16:53:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b3e5086a8625760545c976d2a0156106946bb0c
Cr-Commit-Position: refs/heads/master@{#311912}

Powered by Google App Engine
This is Rietveld 408576698