components/omnibox/search_suggestion_parser.cc - Issue 832943002: Don't set suggestion type to SEARCH_SUGGEST_ANSWER on search responses with Answers attached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/search_suggestion_parser.cc

Issue 832943002: Don't set suggestion type to SEARCH_SUGGEST_ANSWER on search responses with Answers attached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/omnibox/search_suggestion_parser.cc

diff --git a/components/omnibox/search_suggestion_parser.cc b/components/omnibox/search_suggestion_parser.cc

index d8452ee9465435f6046366ce829e6e5fe1dd27fe..7e06d950ce574aba956dbe9323c34df7927e2542 100644

--- a/components/omnibox/search_suggestion_parser.cc

+++ b/components/omnibox/search_suggestion_parser.cc

@@ -500,7 +500,6 @@ bool SearchSuggestionParser::ParseSuggestResults(

int answer_type = 0;

if (answer && base::StringToInt(answer_type_str, &answer_type)) {

answer_parsed_successfully = true;

- match_type = AutocompleteMatchType::SEARCH_SUGGEST_ANSWER;

answer->set_type(answer_type);

answer->AddImageURLsTo(&results->answers_image_urls);

« no previous file with comments | « no previous file | no next file » | no next file with comments »