Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 83293008: Fix CreateHRGNFromSkPath to support arbitrary SkPaths. (Closed)

Created:
7 years, 1 month ago by Wez
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix CreateHRGNFromSkPath to support arbitrary SkPaths. Also adds tests for CreateHRGNFromSkPath and CreateHRGNFromSkRegion. BUG=322360 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251555

Patch Set 1 #

Patch Set 2 : Add test for non-contiguous SkPath. #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -10 lines) Patch
M ui/gfx/gfx_tests.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/path_win.cc View 1 2 1 chunk +4 lines, -10 lines 0 comments Download
A ui/gfx/path_win_unittest.cc View 1 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Wez
PTAL
7 years ago (2013-12-07 06:44:49 UTC) #1
Ben Goodger (Google)
lgtm
7 years ago (2013-12-09 19:16:56 UTC) #2
Wez
The CQ bit was checked by wez@chromium.org
6 years, 10 months ago (2014-02-11 00:58:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/83293008/70001
6 years, 10 months ago (2014-02-11 01:00:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-11 01:00:57 UTC) #5
commit-bot: I haz the power
Failed to apply patch for ui/gfx/path_win.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-11 01:00:58 UTC) #6
Wez
The CQ bit was checked by wez@chromium.org
6 years, 10 months ago (2014-02-15 05:47:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/83293008/210001
6 years, 10 months ago (2014-02-15 05:48:03 UTC) #8
commit-bot: I haz the power
Change committed as 251555
6 years, 10 months ago (2014-02-15 08:19:25 UTC) #9
tapted
6 years, 10 months ago (2014-02-17 03:26:11 UTC) #10
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/169223002/ by tapted@chromium.org.

The reason for reverting is: As per http://crbug.com/344243 - this CL makes the
App Launcher window invisible under Aero, and packaged app windows invisible
under non-Aero (RDP/Classic theme/etc.).

BUG=344243.

Powered by Google App Engine
This is Rietveld 408576698