Issue 169223002: Revert of Fix CreateHRGNFromSkPath to support arbitrary SkPaths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 169223002: Revert of Fix CreateHRGNFromSkPath to support arbitrary SkPaths. (Closed)

Created:
6 years, 10 months ago by tapted

Modified:
6 years, 10 months ago

Reviewers:
Ben Goodger (Google), Wez

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Fix CreateHRGNFromSkPath to support arbitrary SkPaths. (https://codereview.chromium.org/83293008/) Reason for revert: As per http://crbug.com/344243 - this CL makes the App Launcher window invisible under Aero, and packaged app windows invisible under non-Aero (RDP/Classic theme/etc.). BUG=344243 Original issue's description: > Fix CreateHRGNFromSkPath to support arbitrary SkPaths. > > Also adds tests for CreateHRGNFromSkPath and CreateHRGNFromSkRegion. > > BUG=322360 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251555 TBR=ben@chromium.org,wez@chromium.org NOTREECHECKS=true NOTRY=true BUG=322360 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251636

Created: 6 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -87 lines)			Patch
M	ui/gfx/path_win.cc	View	1 chunk	+10 lines, -4 lines	0 comments	Download
D	ui/gfx/path_win_unittest.cc	View	1 chunk	+0 lines, -82 lines	0 comments	Download
M	ui/ui_unittests.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

tapted

Created Revert of Fix CreateHRGNFromSkPath to support arbitrary SkPaths.

6 years, 10 months ago (2014-02-17 03:26:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/169223002/1

6 years, 10 months ago (2014-02-17 03:26:27 UTC) #2

Message was sent while issue was closed.

Change committed as 251636