Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: Source/core/animation/LengthStyleInterpolation.cpp

Issue 832873002: Animation: Remove ASSERT_NOT_REACHED from LengthStyleInterpolation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add return 0px after ASSERT_NOT_REACHED() Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/LengthStyleInterpolation.cpp
diff --git a/Source/core/animation/LengthStyleInterpolation.cpp b/Source/core/animation/LengthStyleInterpolation.cpp
index 225341dfc0876cfe39b9750c05c7999889598e30..c6b50b659a72db51d5b43630b9573a7eea26fe9f 100644
--- a/Source/core/animation/LengthStyleInterpolation.cpp
+++ b/Source/core/animation/LengthStyleInterpolation.cpp
@@ -96,6 +96,7 @@ PassRefPtrWillBeRawPtr<CSSPrimitiveValue> LengthStyleInterpolation::interpolable
switch (unitTypeCount) {
case 0:
ASSERT_NOT_REACHED();
shans 2015/01/07 23:07:49 Instead remove this assert and add a TODO to fix t
evemj (not active) 2015/01/07 23:28:03 Done.
+ return CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_PX);
case 1:
for (size_t i = 0; i < CSSPrimitiveValue::LengthUnitTypeCount; i++) {
const InterpolableNumber *subValueType = toInterpolableNumber(listOfTypes->get(i));
« Source/core/animation/InterpolableValue.cpp ('K') | « Source/core/animation/InterpolableValue.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698