Source/core/animation/InterpolableValue.cpp - Issue 832873002: Animation: Remove ASSERT_NOT_REACHED from LengthStyleInterpolation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/InterpolableValue.cpp

Issue 832873002: Animation: Remove ASSERT_NOT_REACHED from LengthStyleInterpolation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add return 0px after ASSERT_NOT_REACHED() Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/InterpolableValue.cpp

diff --git a/Source/core/animation/InterpolableValue.cpp b/Source/core/animation/InterpolableValue.cpp

index a8117c760698818c3d445aa0fa374c3a485ec456..41d4703249b248a14bf5b39f754c8edfe911487d 100644

--- a/Source/core/animation/InterpolableValue.cpp

+++ b/Source/core/animation/InterpolableValue.cpp

@@ -19,7 +19,7 @@ void InterpolableNumber::interpolate(const InterpolableValue &to, const double p

else if (progress == 1)

resultNumber.m_value = toNumber.m_value;

else

- resultNumber.m_value = m_value * (1 - progress) + toNumber.m_value * progress;

+ resultNumber.m_value = m_value + (toNumber.m_value - m_value) * progress;

shans 2015/01/07 23:07:49 Don't do this - you'll cause interpolation from la

evemj (not active) 2015/01/07 23:28:03 Done.

}

void InterpolableBool::interpolate(const InterpolableValue &to, const double progress, InterpolableValue& result) const

« no previous file with comments | « no previous file | Source/core/animation/LengthStyleInterpolation.cpp » ('j') | Source/core/animation/LengthStyleInterpolation.cpp » ('J')