Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 832703003: Get rid of g_timeMap global object. (Closed)

Created:
5 years, 11 months ago by brucedawson
Modified:
5 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get rid of g_timeMap global object. g_timeMap is a global variable with a constructor and destructor so it must be removed. BUG=441899 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c5f520cd3a2571376d6ae12112f6d4cd82f386a5

Patch Set 1 #

Patch Set 2 : Adding clarifying comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 1 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
brucedawson
This is possibly the last initializer that needs removing from pdfium. The remaining one is ...
5 years, 11 months ago (2015-01-05 22:54:02 UTC) #2
Tom Sepez
Rubberstamp LGTM.
5 years, 11 months ago (2015-01-05 22:58:01 UTC) #3
brucedawson
5 years, 11 months ago (2015-01-05 23:09:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c5f520cd3a2571376d6ae12112f6d4cd82f386a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698