Issue 832703003: Get rid of g_timeMap global object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 832703003: Get rid of g_timeMap global object. (Closed)

Created:
5 years, 11 months ago by brucedawson

Modified:
5 years, 11 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Get rid of g_timeMap global object. g_timeMap is a global variable with a constructor and destructor so it must be removed. BUG=441899 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c5f520cd3a2571376d6ae12112f6d4cd82f386a5

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	fpdfsdk/src/pdfwindow/PWL_Wnd.cpp	View	1	4 chunks	+9 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

brucedawson

This is possibly the last initializer that needs removing from pdfium. The remaining one is ...

5 years, 11 months ago (2015-01-05 22:54:02 UTC) #2

brucedawson

5 years, 11 months ago (2015-01-05 23:09:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c5f520cd3a2571376d6ae12112f6d4cd82f386a5 (presubmit successful).