chrome/browser/BUILD.gn - Issue 832583007: Add GN files for chrome_elf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 832583007: Add GN files for chrome_elf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update compiler options for release to fix chrome_elf. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index d210d1cf70adfe380e3de3fb555daf872130a725..b47f78072568d645095e02e28ff866a7051f591d 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -641,14 +641,14 @@ static_library("browser") {

deps += [

"//chrome:version_header",

"//chrome/installer/util:strings",

+ "//chrome_elf",

+ "//chrome_elf:chrome_elf_constants",

+ "//chrome_elf:dll_hash",

"//third_party/iaccessible2",

"//third_party/isimpledom",

"//third_party/wtl",

#"chrome_process_finder", TODO(GYP)

- #"../chrome_elf/chrome_elf.gyp:chrome_elf", TODO(GYP)

- #"../chrome_elf/chrome_elf.gyp:chrome_elf_constants", TODO(GYP)

- #"../chrome_elf/chrome_elf.gyp:dll_hash", TODO(GYP)

#"../google_update/google_update.gyp:google_update", TODO(GYP)

"//ui/metro_viewer",

"//win8:metro_viewer",