build/config/compiler/BUILD.gn - Issue 832583007: Add GN files for chrome_elf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 832583007: Add GN files for chrome_elf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update compiler options for release to fix chrome_elf. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index c61964fc86db552551b3dda4a440cdc891427f0a..9e03e30311817d162406249a1c974a3ba1f9d92e 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -849,7 +849,17 @@ if (is_win) {

"/Oy-", # disable omitting frame pointers, must be after /o2.

"/Os", # favor size over speed.

]

- common_optimize_on_ldflags = []

+ if (!is_asan) {

+ common_optimize_on_cflags += [

+ # Put data in separate COMDATs. This allows the linker

+ # to put bit-identical constants at the same address even if

+ # they're unrelated constants, which saves binary size.

+ # This optimization can't be used when ASan is enabled because

+ # it is not compatible with the ASan ODR checker.

+ "/Gw",

Slava Chigrin 2015/01/19 12:41:23 Like that in GYP https://code.google.com/p/chromiu

+ ]

+ }

+ common_optimize_on_ldflags = [ "/OPT:REF" ]

Slava Chigrin 2015/01/19 12:41:23 Like that https://code.google.com/p/chromium/codes

} else {

common_optimize_on_cflags = [

# Don't emit the GCC version ident directives, they just end up in the

« no previous file with comments | « no previous file | chrome/BUILD.gn » ('j') | no next file with comments »