Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 832413005: Hack around broken snapshot generation in the GN build on Android. (Closed)

Created:
5 years, 11 months ago by eseidel
Modified:
5 years, 11 months ago
CC:
adamk, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Hack around broken snapshot generation in the GN build on Android. The generated snapshot just crashes on the device, but disabling snapshots allows us to run V8 just fine which is sufficient for our purposes at this point. Mojo/Sky are GN-only so we depend on the V8 GN build even if it's not considered production for Chromium yet. R=jochen@chromium.org Committed: https://crrev.com/3e97df1ee8b8bfdddd63ad3c7b79960d24c83b74 Cr-Commit-Position: refs/heads/master@{#25982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
eseidel
5 years, 11 months ago (2015-01-07 01:51:41 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-07 13:43:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832413005/1
5 years, 11 months ago (2015-01-07 20:12:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 20:39:30 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3e97df1ee8b8bfdddd63ad3c7b79960d24c83b74 Cr-Commit-Position: refs/heads/master@{#25982}
5 years, 11 months ago (2015-01-07 20:39:43 UTC) #6
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/841043002/ by machenbach@chromium.org. ...
5 years, 11 months ago (2015-01-08 10:43:57 UTC) #7
eseidel1
Great Can we just fix the ASSERT instead? The snapshot definitely does not work on ...
5 years, 11 months ago (2015-01-08 19:14:06 UTC) #9
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-08 19:23:01 UTC) #10
Message was sent while issue was closed.
as far as I see the assert() is actually correct :)

I'm not sure whether hacking the entire config to skip the snapshot on android
is the right way forward even temporarily. Since Brett is trying to bring up d8
for chromium, we'll need a working snapshot anyway.

maybe adding a block like this
https://code.google.com/p/chromium/codesearch#chromium/src/v8/BUILD.gn&l=125 for
arm should be already enough to get the snapshot working?

Powered by Google App Engine
This is Rietveld 408576698