Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 832383004: Revert of Support multiple video decoders and encoders (Closed)

Created:
5 years, 11 months ago by nhiroki
Modified:
5 years, 11 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support multiple video decoders and encoders (patchset #14 id:260001 of https://codereview.chromium.org/826663002/) Reason for revert: This causes compile failure on "Linux ChromiumOS Ozone Builder Build" http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/9379 Original issue's description: > Support multiple video decoders and encoders > > Some platforms have multiple video decoders and encoders. > For decode and encoder, return the first succeed initialized VDA and VEA > from all possible platforms. GetSupportedProfile return all possible profiles > from all encoders. > > BUG=445016 > TEST=Tested on squawks. For decoder, make sure V4L2 initialization > failed and VAAPI successed. For encoder, test on extension. > > Committed: https://crrev.com/fce5ccd14c3676b960917c095a050b7a76b15227 > Cr-Commit-Position: refs/heads/master@{#310232} TBR=posciak@chromium.org,wuchengli@chromium.org,piman@chromium.org,henryhsu@chromium.org NOTREECHECKS=true NOTRY=true BUG=445016 Committed: https://crrev.com/f3af1862ef941a1ed12a9a98df1ae78e15d6fed1 Cr-Commit-Position: refs/heads/master@{#310238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -249 lines) Patch
M content/common/BUILD.gn View 2 chunks +5 lines, -9 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.h View 1 chunk +2 lines, -17 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +59 lines, -107 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.h View 1 chunk +5 lines, -11 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 4 chunks +36 lines, -71 lines 0 comments Download
M content/common/gpu/media/v4l2_image_processor.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/common/gpu/media/v4l2_image_processor.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/v4l2_video_device.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_common.gypi View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nhiroki
Created Revert of Support multiple video decoders and encoders
5 years, 11 months ago (2015-01-07 05:45:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832383004/1
5 years, 11 months ago (2015-01-07 05:45:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 05:47:05 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 05:48:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3af1862ef941a1ed12a9a98df1ae78e15d6fed1
Cr-Commit-Position: refs/heads/master@{#310238}

Powered by Google App Engine
This is Rietveld 408576698