Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 832343003: Delay string conversion of attribute names until needed. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
aandrey, adamk, pfeldman
CC:
blink-reviews, eustas+blink_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis, haraken
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Delay string conversion of attribute names until needed. Upon attribute creation/update/removal wrt a qualified name, that operation is reported to inspector via the InspectorInstrumentation interface. Do that without stringifying the qualified name first, as the notification and its stringified name may very well not be made use of. If, for instance, developer tools aren't active. Gains 4% on dromaeo.domattr.dom_attr_setAttribute. R=adamk BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M Source/core/dom/Element.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. Gains are modest overall, but I don't see a good reason ...
5 years, 11 months ago (2015-01-05 21:47:51 UTC) #2
adamk
lgtm
5 years, 11 months ago (2015-01-05 21:58:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832343003/1
5 years, 11 months ago (2015-01-05 22:06:42 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 22:52:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187871

Powered by Google App Engine
This is Rietveld 408576698