Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 832343003: Delay string conversion of attribute names until needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.h ('k') | Source/core/inspector/InspectorInstrumentation.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDOMAgent.cpp
diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp
index 271d39e66a9215db9f7cfd06c49e299f71117659..c933be49f12f53d79e2e00a25f2853afd8c6e23c 100644
--- a/Source/core/inspector/InspectorDOMAgent.cpp
+++ b/Source/core/inspector/InspectorDOMAgent.cpp
@@ -2006,7 +2006,7 @@ void InspectorDOMAgent::willModifyDOMAttr(Element*, const AtomicString& oldValue
m_suppressAttributeModifiedEvent = (oldValue == newValue);
}
-void InspectorDOMAgent::didModifyDOMAttr(Element* element, const String& name, const AtomicString& value)
+void InspectorDOMAgent::didModifyDOMAttr(Element* element, const QualifiedName& name, const AtomicString& value)
{
bool shouldSuppressEvent = m_suppressAttributeModifiedEvent;
m_suppressAttributeModifiedEvent = false;
@@ -2021,10 +2021,10 @@ void InspectorDOMAgent::didModifyDOMAttr(Element* element, const String& name, c
if (m_domListener)
m_domListener->didModifyDOMAttr(element);
- m_frontend->attributeModified(id, name, value);
+ m_frontend->attributeModified(id, name.toString(), value);
}
-void InspectorDOMAgent::didRemoveDOMAttr(Element* element, const String& name)
+void InspectorDOMAgent::didRemoveDOMAttr(Element* element, const QualifiedName& name)
{
int id = boundNodeId(element);
// If node is not mapped yet -> ignore the event.
@@ -2034,7 +2034,7 @@ void InspectorDOMAgent::didRemoveDOMAttr(Element* element, const String& name)
if (m_domListener)
m_domListener->didModifyDOMAttr(element);
- m_frontend->attributeRemoved(id, name);
+ m_frontend->attributeRemoved(id, name.toString());
}
void InspectorDOMAgent::styleAttributeInvalidated(const WillBeHeapVector<RawPtrWillBeMember<Element> >& elements)
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.h ('k') | Source/core/inspector/InspectorInstrumentation.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698