Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: extensions/common/manifest_handlers/oauth2_manifest_handler.cc

Issue 832333008: Add a CHECK to investigate crash in OAuth2ManifestHandler::Parse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_handlers/oauth2_manifest_handler.cc
diff --git a/extensions/common/manifest_handlers/oauth2_manifest_handler.cc b/extensions/common/manifest_handlers/oauth2_manifest_handler.cc
index 1d32ecb09fd87cb785dcb8a244d33ad136903792..3bcf95880c6357300b53a39d99e6a6878a32e623 100644
--- a/extensions/common/manifest_handlers/oauth2_manifest_handler.cc
+++ b/extensions/common/manifest_handlers/oauth2_manifest_handler.cc
@@ -53,6 +53,10 @@ bool OAuth2ManifestHandler::Parse(Extension* extension,
return false;
}
+ // This should not be possible, but it looks like the source of the crash in
+ // http://crbug.com/445683. Perhaps something is overwriting the stack.
+ CHECK(info);
+
// HasPath checks for whether the manifest is allowed to have
// oauth2.auto_approve based on whitelist, and if it is present.
// GetBoolean reads the value of auto_approve directly from dict to prevent
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698