Add a CHECK to investigate crash in OAuth2ManifestHandler::Parse

extensions/common/manifest_handlers/oauth2_manifest_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/manifest_handlers/oauth2_manifest_handler.h"
 
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 35 matching lines @@
 
 bool OAuth2ManifestHandler::Parse(Extension* extension,
                                   base::string16* error) {
   scoped_ptr<OAuth2Info> info(new OAuth2Info);
   const base::DictionaryValue* dict = NULL;
   if (!extension->manifest()->GetDictionary(keys::kOAuth2, &dict)) {
     *error = base::ASCIIToUTF16(errors::kInvalidOAuth2ClientId);
     return false;
   }
 
+  // This should not be possible, but it looks like the source of the crash in
+  // http://crbug.com/445683. Perhaps something is overwriting the stack.
+  CHECK(info);
+
   // HasPath checks for whether the manifest is allowed to have
   // oauth2.auto_approve based on whitelist, and if it is present.
   // GetBoolean reads the value of auto_approve directly from dict to prevent
   // duplicate checking.
   if (extension->manifest()->HasPath(keys::kOAuth2AutoApprove) &&
       !dict->GetBoolean(kAutoApprove, &info->auto_approve)) {
     *error = base::ASCIIToUTF16(errors::kInvalidOAuth2AutoApprove);
     return false;
   }
 
@@ skipping 23 matching lines @@
 
   extension->SetManifestData(keys::kOAuth2, info.release());
   return true;
 }
 
 const std::vector<std::string> OAuth2ManifestHandler::Keys() const {
   return SingleKey(keys::kOAuth2);
 }
 
 }  // namespace extensions