Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 832333008: Add a CHECK to investigate crash in OAuth2ManifestHandler::Parse (Closed)

Created:
5 years, 11 months ago by James Cook
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a CHECK to investigate crash in OAuth2ManifestHandler::Parse I don't see anything wrong with the code, so adding a CHECK to investigate further. If there are no crashes on this CHECK it can be removed in M42. BUG=445683 TEST=extensions_unittests Committed: https://crrev.com/ec299aa0ff64e7b4647d376c93d6927ecc85d070 Cr-Commit-Position: refs/heads/master@{#310107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M extensions/common/manifest_handlers/oauth2_manifest_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
James Cook
courage, PTAL
5 years, 11 months ago (2015-01-05 22:21:48 UTC) #2
Michael Courage
lgtm
5 years, 11 months ago (2015-01-05 23:29:11 UTC) #3
James Cook
rockot, can I have OWNERS?
5 years, 11 months ago (2015-01-06 00:09:25 UTC) #5
Ken Rockot(use gerrit already)
On 2015/01/06 00:09:25, James Cook wrote: > rockot, can I have OWNERS? lgtm
5 years, 11 months ago (2015-01-06 04:05:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832333008/1
5 years, 11 months ago (2015-01-06 16:50:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 17:55:23 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 17:56:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec299aa0ff64e7b4647d376c93d6927ecc85d070
Cr-Commit-Position: refs/heads/master@{#310107}

Powered by Google App Engine
This is Rietveld 408576698