Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 832293003: Cast: Speed up some long running tests in DEBUG mode. (Closed)

Created:
5 years, 11 months ago by hubbe
Modified:
5 years, 11 months ago
Reviewers:
miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cast: Speed up some long running tests in DEBUG mode. These tests iterate over 10000 frames, and with debug mode being 13+ times slower than release mode, this ends up taking too long. Hopefully we won't loose much coverage by reducing the number of iterations in debug mode. BUG=448035, 448511 Committed: https://crrev.com/ea0c0425eaa9a05c7bce4408f2ac7919b21c6be7 Cr-Commit-Position: refs/heads/master@{#311512}

Patch Set 1 #

Patch Set 2 : re-enable test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -25 lines) Patch
M media/cast/test/end2end_unittest.cc View 1 7 chunks +38 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hubbe
5 years, 11 months ago (2015-01-13 19:19:16 UTC) #2
miu
lgtm
5 years, 11 months ago (2015-01-14 05:14:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832293003/20001
5 years, 11 months ago (2015-01-14 05:14:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/48838)
5 years, 11 months ago (2015-01-14 05:37:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832293003/20001
5 years, 11 months ago (2015-01-14 18:02:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 18:11:32 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:12:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea0c0425eaa9a05c7bce4408f2ac7919b21c6be7
Cr-Commit-Position: refs/heads/master@{#311512}

Powered by Google App Engine
This is Rietveld 408576698