Cast: Speed up some long running tests in DEBUG mode.

media/cast/test/end2end_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This test generate synthetic data. For audio it's a sinusoid waveform with
 // frequency kSoundFrequency and different amplitudes. For video it's a pattern
 // that is shifting by one pixel per frame, each pixels neighbors right and down
 // is this pixels value +1, since the pixel value is 8 bit it will wrap
 // frequently within the image. Visually this will create diagonally color bands
 // that moves across the screen
@@ skipping 1339 matching lines @@
 
   int frames_counter = 0;
   for (; frames_counter < 1000; ++frames_counter) {
     SendFakeVideoFrame(testing_clock_sender_->NowTicks());
     RunTasks(kFrameTimerMs);
   }
   RunTasks(2 * kFrameTimerMs + 1);  // Empty the pipeline.
   EXPECT_EQ(1000ul, video_ticks_.size());
 }
 
+// The following tests run many many iterations to make sure that
+// buffers don't fill, timers don't go askew etc. However, these
+// high-level tests are too expensive in debug mode, so we reduce
+// the iterations in debug mode.
+#if defined(NDEBUG)
+const size_t kLongTestIterations = 10000;
+#else
+const size_t kLongTestIterations = 1000;
+#endif
+
 TEST_F(End2EndTest, ReceiverClockFast) {
   Configure(CODEC_VIDEO_FAKE, CODEC_AUDIO_PCM16, 32000,
             1);
   Create();
   StartBasicPlayer();
   SetReceiverSkew(2.0, base::TimeDelta::FromMicroseconds(1234567));
 
-  int frames_counter = 0;
-  for (; frames_counter < 10000; ++frames_counter) {
+  for (size_t frames_counter = 0;
+       frames_counter < kLongTestIterations;
+       ++frames_counter) {
     SendFakeVideoFrame(testing_clock_sender_->NowTicks());
     RunTasks(kFrameTimerMs);
   }
   RunTasks(2 * kFrameTimerMs + 1);  // Empty the pipeline.
-  EXPECT_EQ(10000ul, video_ticks_.size());
+  EXPECT_EQ(kLongTestIterations, video_ticks_.size());
 }
 
 TEST_F(End2EndTest, ReceiverClockSlow) {
   Configure(CODEC_VIDEO_FAKE, CODEC_AUDIO_PCM16, 32000,
             1);
   Create();
   StartBasicPlayer();
   SetReceiverSkew(0.5, base::TimeDelta::FromMicroseconds(-765432));
 
-  int frames_counter = 0;
-  for (; frames_counter < 10000; ++frames_counter) {
+  for (size_t frames_counter = 0;
+       frames_counter < kLongTestIterations;
+       ++frames_counter) {
     SendFakeVideoFrame(testing_clock_sender_->NowTicks());
     RunTasks(kFrameTimerMs);
   }
   RunTasks(2 * kFrameTimerMs + 1);  // Empty the pipeline.
-  EXPECT_EQ(10000ul, video_ticks_.size());
+  EXPECT_EQ(kLongTestIterations, video_ticks_.size());
 }
 
 TEST_F(End2EndTest, SmoothPlayoutWithFivePercentClockRateSkew) {
   Configure(CODEC_VIDEO_FAKE, CODEC_AUDIO_PCM16, 32000,
             1);
   Create();
   StartBasicPlayer();
   SetReceiverSkew(1.05, base::TimeDelta::FromMilliseconds(-42));
 
   // Expect smooth playout when there is 5% skew.
   SetExpectedVideoPlayoutSmoothness(
       base::TimeDelta::FromMilliseconds(kFrameTimerMs) * 90 / 100,
       base::TimeDelta::FromMilliseconds(kFrameTimerMs) * 110 / 100,
       base::TimeDelta::FromMilliseconds(kFrameTimerMs) / 10);
 
-  int frames_counter = 0;
-  for (; frames_counter < 10000; ++frames_counter) {
+  for (size_t frames_counter = 0;
+       frames_counter < kLongTestIterations;
+       ++frames_counter) {
     SendFakeVideoFrame(testing_clock_sender_->NowTicks());
     RunTasks(kFrameTimerMs);
   }
   RunTasks(2 * kFrameTimerMs + 1);  // Empty the pipeline.
-  EXPECT_EQ(10000ul, video_ticks_.size());
+  EXPECT_EQ(kLongTestIterations, video_ticks_.size());
 }
 
 TEST_F(End2EndTest, EvilNetwork) {
   Configure(CODEC_VIDEO_FAKE, CODEC_AUDIO_PCM16, 32000,
             1);
   receiver_to_sender_.SetPacketPipe(test::EvilNetwork().Pass());
   sender_to_receiver_.SetPacketPipe(test::EvilNetwork().Pass());
   Create();
   StartBasicPlayer();
 
-  int frames_counter = 0;
-  for (; frames_counter < 10000; ++frames_counter) {
+  for (size_t frames_counter = 0;
+       frames_counter < kLongTestIterations;
+       ++frames_counter) {
     SendFakeVideoFrame(testing_clock_sender_->NowTicks());
     RunTasks(kFrameTimerMs);
   }
   base::TimeTicks test_end = testing_clock_receiver_->NowTicks();
   RunTasks(100 * kFrameTimerMs + 1);  // Empty the pipeline.
-  EXPECT_GT(video_ticks_.size(), 100ul);
-  VLOG(1) << "Fully transmitted " << video_ticks_.size()
-          << " out of 10000 frames.";
+  EXPECT_GT(video_ticks_.size(), kLongTestIterations / 100);
+  VLOG(1) << "Fully transmitted " << video_ticks_.size() << " frames.";
   EXPECT_LT((video_ticks_.back().second - test_end).InMilliseconds(), 1000);
 }
 
 // Tests that a system configured for 30 FPS drops frames when input is provided
 // at a much higher frame rate.
 TEST_F(End2EndTest, ShoveHighFrameRateDownYerThroat) {
   Configure(CODEC_VIDEO_FAKE, CODEC_AUDIO_PCM16, 32000,
             1);
   receiver_to_sender_.SetPacketPipe(test::EvilNetwork().Pass());
   sender_to_receiver_.SetPacketPipe(test::EvilNetwork().Pass());
   Create();
   StartBasicPlayer();
 
-  int frames_counter = 0;
-  for (; frames_counter < 10000; ++frames_counter) {
+  for (size_t frames_counter = 0;
+       frames_counter < kLongTestIterations;
+       ++frames_counter) {
     SendFakeVideoFrame(testing_clock_sender_->NowTicks());
     RunTasks(10 /* 10 ms, but 33.3 expected by system */);
   }
   base::TimeTicks test_end = testing_clock_receiver_->NowTicks();
   RunTasks(100 * kFrameTimerMs + 1);  // Empty the pipeline.
-  EXPECT_LT(100ul, video_ticks_.size());
-  EXPECT_GE(3334ul, video_ticks_.size());
-  VLOG(1) << "Fully transmitted " << video_ticks_.size()
-          << " out of 10000 frames.";
+  EXPECT_LT(kLongTestIterations / 100, video_ticks_.size());
+  EXPECT_GE(kLongTestIterations / 3, video_ticks_.size());
+  VLOG(1) << "Fully transmitted " << video_ticks_.size() << " frames.";
   EXPECT_LT((video_ticks_.back().second - test_end).InMilliseconds(), 1000);
 }
 
-// Disabled due to flake: http://crbug.com/448511
-TEST_F(End2EndTest, DISABLED_OldPacketNetwork) {
+TEST_F(End2EndTest, OldPacketNetwork) {
   Configure(CODEC_VIDEO_FAKE, CODEC_AUDIO_PCM16, 32000, 1);
   sender_to_receiver_.SetPacketPipe(test::NewRandomDrop(0.01));
   scoped_ptr<test::PacketPipe> echo_chamber(
       test::NewDuplicateAndDelay(1, 10 * kFrameTimerMs));
   echo_chamber->AppendToPipe(
       test::NewDuplicateAndDelay(1, 20 * kFrameTimerMs));
   echo_chamber->AppendToPipe(
       test::NewDuplicateAndDelay(1, 40 * kFrameTimerMs));
   echo_chamber->AppendToPipe(
       test::NewDuplicateAndDelay(1, 80 * kFrameTimerMs));
   echo_chamber->AppendToPipe(
       test::NewDuplicateAndDelay(1, 160 * kFrameTimerMs));
 
   receiver_to_sender_.SetPacketPipe(echo_chamber.Pass());
   Create();
   StartBasicPlayer();
 
   SetExpectedVideoPlayoutSmoothness(
       base::TimeDelta::FromMilliseconds(kFrameTimerMs) * 90 / 100,
       base::TimeDelta::FromMilliseconds(kFrameTimerMs) * 110 / 100,
       base::TimeDelta::FromMilliseconds(kFrameTimerMs) / 10);
 
-  int frames_counter = 0;
-  for (; frames_counter < 10000; ++frames_counter) {
+  for (size_t frames_counter = 0;
+       frames_counter < kLongTestIterations;
+       ++frames_counter) {
     SendFakeVideoFrame(testing_clock_sender_->NowTicks());
     RunTasks(kFrameTimerMs);
   }
   RunTasks(100 * kFrameTimerMs + 1);  // Empty the pipeline.
 
-  EXPECT_EQ(10000ul, video_ticks_.size());
+  EXPECT_EQ(kLongTestIterations, video_ticks_.size());
 }
 
 TEST_F(End2EndTest, TestSetPlayoutDelay) {
   Configure(CODEC_VIDEO_FAKE, CODEC_AUDIO_PCM16, 32000, 1);
   video_sender_config_.min_playout_delay =
       video_sender_config_.max_playout_delay;
   audio_sender_config_.min_playout_delay =
       audio_sender_config_.max_playout_delay;
   video_sender_config_.max_playout_delay = base::TimeDelta::FromSeconds(1);
   audio_sender_config_.max_playout_delay = base::TimeDelta::FromSeconds(1);
@@ skipping 27 matching lines @@
   EXPECT_LT(jump, 220u);
 }
 
 // TODO(pwestin): Add repeatable packet loss test.
 // TODO(pwestin): Add test for misaligned send get calls.
 // TODO(pwestin): Add more tests that does not resample.
 // TODO(pwestin): Add test when we have starvation for our RunTask.
 
 }  // namespace cast
 }  // namespace media