Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: include/core/SkPath.h

Issue 832083002: Cleanup isRect variants (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Remove old entry points completely Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkPath.cpp » ('j') | src/core/SkPath.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkPath.h
diff --git a/include/core/SkPath.h b/include/core/SkPath.h
index 4b95e893e2821821aecaf129f9fbea9430b0e266..db83f92da5fc99756c98b1e9a79c6eb5013ccf93 100644
--- a/include/core/SkPath.h
+++ b/include/core/SkPath.h
@@ -239,16 +239,6 @@ public:
*/
bool isLine(SkPoint line[2]) const;
- /** Returns true if the path specifies a rectangle. If so, and if rect is
- not null, set rect to the bounds of the path. If the path does not
- specify a rectangle, return false and ignore rect.
-
- @param rect If not null, returns the bounds of the path if it specifies
- a rectangle
- @return true if the path specifies a rectangle
- */
- bool isRect(SkRect* rect) const { return this->isRect(rect, NULL, NULL); }
-
/** Return the number of points in the path
*/
int countPoints() const;
@@ -592,19 +582,6 @@ public:
*/
PathAsRect asRect(Direction* direction = NULL) const;
- /** Returns true if the path specifies a rectangle. If so, and if isClosed is
- not null, set isClosed to true if the path is closed. Also, if returning true
- and direction is not null, return the rect direction. If the path does not
- specify a rectangle, return false and ignore isClosed and direction.
-
- @param isClosed If not null, set to true if the path is closed
- @param direction If not null, set to the rectangle's direction
- @return true if the path specifies a rectangle
- */
- bool isRect(bool* isClosed, Direction* direction) const {
- return this->isRect(NULL, isClosed, direction);
- }
-
/**
* Returns true if the path specifies a rectangle.
*
@@ -617,7 +594,7 @@ public:
* @param direction If not null, set to the rectangle's direction
* @return true if the path specifies a rectangle
*/
- bool isRect(SkRect* rect, bool* isClosed, Direction* direction) const;
+ bool isRect(SkRect* rect, bool* isClosed = NULL, Direction* direction = NULL) const;
/** Returns true if the path specifies a pair of nested rectangles. If so, and if
rect is not null, set rect[0] to the outer rectangle and rect[1] to the inner
« no previous file with comments | « no previous file | src/core/SkPath.cpp » ('j') | src/core/SkPath.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698