src/core/SkPath.cpp - Issue 832083002: Cleanup isRect variants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPath.cpp

Issue 832083002: Cleanup isRect variants (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Remove old entry points completely Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPath.cpp

diff --git a/src/core/SkPath.cpp b/src/core/SkPath.cpp

index 27b7283263a059bf4d018bd8f2abb6b0358d6510..9231d8bf8a3216011a43f3da47230cd0b3b9b870 100644

--- a/src/core/SkPath.cpp

+++ b/src/core/SkPath.cpp

@@ -531,7 +531,7 @@ SkPath::PathAsRect SkPath::asRect(Direction* direction) const {

SK_COMPILE_ASSERT(1 == kFill_PathAsRect, path_as_rect_mismatch);

SK_COMPILE_ASSERT(2 == kStroke_PathAsRect, path_as_rect_mismatch);

bool isClosed = false;

- return (PathAsRect) (isRect(&isClosed, direction) + isClosed);

+ return (PathAsRect) (this->isRect(NULL, &isClosed, direction) + isClosed);

reed1 2015/01/05 14:25:50 now that is a compact line of code. Can we somehow

}

bool SkPath::isRect(SkRect* rect, bool* isClosed, Direction* direction) const {