Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 83203004: Cleanup: Do not use wstrings in the cloud print dialog. (Closed)

Created:
7 years, 1 month ago by Lei Zhang
Modified:
7 years, 1 month ago
Reviewers:
Scott Byer
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Do not use wstrings in the cloud print dialog. BUG=23581 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236902

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -52 lines) Patch
M chrome/browser/printing/print_dialog_cloud.cc View 3 chunks +10 lines, -33 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 2 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_unittest.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
7 years, 1 month ago (2013-11-22 21:16:31 UTC) #1
Scott Byer
lgtm
7 years, 1 month ago (2013-11-22 21:55:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/83203004/150001
7 years, 1 month ago (2013-11-22 21:57:17 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-23 01:24:58 UTC) #4
Message was sent while issue was closed.
Change committed as 236902

Powered by Google App Engine
This is Rietveld 408576698