Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: chrome/browser/printing/print_dialog_cloud_internal.h

Issue 83203004: Cleanup: Do not use wstrings in the cloud print dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_dialog_cloud_internal.h
diff --git a/chrome/browser/printing/print_dialog_cloud_internal.h b/chrome/browser/printing/print_dialog_cloud_internal.h
index c2a4d4da8f5be50d15d185670d79266d7f9b4632..9a49d5c964ef45490ec4c22c962b502f1c3a674d 100644
--- a/chrome/browser/printing/print_dialog_cloud_internal.h
+++ b/chrome/browser/printing/print_dialog_cloud_internal.h
@@ -18,12 +18,11 @@
#include "ui/web_dialogs/web_dialog_delegate.h"
#include "ui/web_dialogs/web_dialog_ui.h"
-class GURL;
class CloudPrintWebDialogDelegateTest;
+class GURL;
namespace base {
class ListValue;
-class StringValue;
class Value;
}
@@ -36,18 +35,11 @@ class CloudPrintDataSenderHelper {
: web_ui_(web_ui) {}
virtual ~CloudPrintDataSenderHelper() {}
- // Virtualize the overrides of these three functions from WebUI to
- // facilitate unit testing.
- virtual void CallJavascriptFunction(const std::wstring& function_name);
- virtual void CallJavascriptFunction(const std::wstring& function_name,
- const base::Value& arg);
- virtual void CallJavascriptFunction(const std::wstring& function_name,
+ // Virtualize the overrides of this function from WebUI to facilitate unit
+ // testing.
+ virtual void CallJavascriptFunction(const std::string& function_name,
const base::Value& arg1,
const base::Value& arg2);
- virtual void CallJavascriptFunction(const std::wstring& function_name,
- const base::Value& arg1,
- const base::Value& arg2,
- const base::Value& arg3);
private:
content::WebUI* web_ui_;
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud.cc ('k') | chrome/browser/printing/print_dialog_cloud_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698