Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 83173006: Disable a SyncTest correctly. (Closed)

Created:
7 years, 1 month ago by Ignacio Solla
Modified:
7 years, 1 month ago
Reviewers:
nyquist, bulach
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, kjellander_chromium, kouhei (in TOK)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable a SyncTest correctly. This reverts https://codereview.chromium.org/34603003 and disables the test correctly. I have followed the example of https://codereview.chromium.org/42103005. You can see that the buildbot was trying to run the test today: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/9870/steps/chromiumtestshell_instrumentation_tests/logs/stdio BUG=322562, 309997 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/android/host_driven_tests/SyncTest.py View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ignacio Solla
bulach@chromium.org: Please review changes in nyquist@chromium.org: Please review changes in
7 years, 1 month ago (2013-11-22 17:40:18 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-11-22 17:43:26 UTC) #2
bulach
lgtm (nit: the description should have BUG=X,Y) rather than two BUG lines..
7 years, 1 month ago (2013-11-22 17:45:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igsolla@chromium.org/83173006/1
7 years, 1 month ago (2013-11-22 17:48:26 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 21:05:49 UTC) #5
Message was sent while issue was closed.
Change committed as 236824

Powered by Google App Engine
This is Rietveld 408576698