Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 42103005: Really mark SyncTest as disabled (Closed)

Created:
7 years, 1 month ago by gone
Modified:
7 years, 1 month ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org
Visibility:
Public.

Description

Really mark SyncTest as disabled Reverts https://codereview.chromium.org/39933002/ and disables the test properly. NOTRY=true BUG=311091 R=nyquist@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230892

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/android/host_driven_tests/SyncTest.py View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nyquist
lgtm with comments https://chromiumcodereview.appspot.com/42103005/diff/1/chrome/android/host_driven_tests/SyncTest.py File chrome/android/host_driven_tests/SyncTest.py (right): https://chromiumcodereview.appspot.com/42103005/diff/1/chrome/android/host_driven_tests/SyncTest.py#newcode58 chrome/android/host_driven_tests/SyncTest.py:58: @tests_annotations.DisabledTest Could you add a comment ...
7 years, 1 month ago (2013-10-25 00:34:21 UTC) #1
gone
https://chromiumcodereview.appspot.com/42103005/diff/1/chrome/android/host_driven_tests/SyncTest.py File chrome/android/host_driven_tests/SyncTest.py (right): https://chromiumcodereview.appspot.com/42103005/diff/1/chrome/android/host_driven_tests/SyncTest.py#newcode58 chrome/android/host_driven_tests/SyncTest.py:58: @tests_annotations.DisabledTest On 2013/10/25 00:34:21, nyquist wrote: > Could you ...
7 years, 1 month ago (2013-10-25 00:36:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/42103005/40001
7 years, 1 month ago (2013-10-25 00:44:31 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 01:07:35 UTC) #4
Message was sent while issue was closed. 
Change committed as 230892

Powered by Google App Engine
This is Rietveld 408576698