Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 831693004: Added WebRTC audio quality test using fake device; improved fake device (Closed)

Created:
5 years, 11 months ago by phoglund_chromium
Modified:
5 years, 11 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added WebRTC audio quality test using fake device; improved fake device This finally adds a end-to-end WebRTC audio quality test which includes getUserMedia and the capture path (except, obviously, the os-specific code which actually interacts with the capture device etc). This patch also makes the audio input device generic. It will now convert its input .wav file to suit the audio bus. I had to do this because the PESQ tests require files to be mono, 16-bit and so on. BUG=446859 Committed: https://crrev.com/b0a18bb4d74babb14f98808f0270c540cc2efd13 Cr-Commit-Position: refs/heads/master@{#310736}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -100 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 7 chunks +112 lines, -72 lines 1 comment Download
M chrome/test/data/webrtc/resources/human-voice-linux.wav.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webrtc/resources/human-voice-mac.wav.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webrtc/resources/human-voice-win.wav.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_input_stream.h View 3 chunks +7 lines, -1 line 0 comments Download
M media/audio/fake_audio_input_stream.cc View 6 chunks +29 lines, -21 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
phoglund_chromium
https://codereview.chromium.org/831693004/diff/1/chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc File chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc (right): https://codereview.chromium.org/831693004/diff/1/chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc#newcode680 chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc:680: // Note: the sound clip is about 13 seconds: ...
5 years, 11 months ago (2015-01-07 15:16:26 UTC) #2
henrika (OOO until Aug 14)
LGTM % (the fact that I might not understand all the details in the actual ...
5 years, 11 months ago (2015-01-07 15:20:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831693004/1
5 years, 11 months ago (2015-01-08 15:22:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/34034)
5 years, 11 months ago (2015-01-08 15:29:33 UTC) #7
phoglund_chromium
Dale: need approval for the comment change in media_switches (context: I made the fake device ...
5 years, 11 months ago (2015-01-08 15:51:08 UTC) #10
DaleCurtis
lgtm
5 years, 11 months ago (2015-01-08 22:04:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831693004/1
5 years, 11 months ago (2015-01-09 07:42:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 08:14:48 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 08:15:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0a18bb4d74babb14f98808f0270c540cc2efd13
Cr-Commit-Position: refs/heads/master@{#310736}

Powered by Google App Engine
This is Rietveld 408576698