Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 831663008: Subzero: Remove the IceV_RegManager enum value. (Closed)

Created:
5 years, 11 months ago by Jim Stichnoth
Modified:
5 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Remove the IceV_RegManager enum value. This hasn't been used in a very long time, and there's no intention of using it again. Originally there was the idea of a "fast" block-local register allocator for an O1-like configuration, which would allocate registers for infinite-weight temporaries during target lowering, using a "local register manager". This verbose option was for tracing execution of this register manager. However, by now it seems unlikely that this would do a better/faster job than the current Om1 register allocation approach, which reuses the linear-scan code quite effectively and does very well at separation of concerns. So adios IceV_RegManager! BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=769be681993b128a4898af2fba56f2135f921ecf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/IceDefs.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/llvm2ice.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
5 years, 11 months ago (2015-01-15 14:14:11 UTC) #2
jvoung (off chromium)
lgtm
5 years, 11 months ago (2015-01-15 16:16:34 UTC) #3
Jim Stichnoth
5 years, 11 months ago (2015-01-15 17:05:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
769be681993b128a4898af2fba56f2135f921ecf (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698