Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 831423005: Split out the extensions gin::Runner implementation into a separate class. (Closed)

Created:
5 years, 11 months ago by Sam McNally
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split out the extensions gin::Runner implementation into a separate class. The gin::Runner should be destroyed when the JS context is so that its weak pointers are invalidated and any outstanding callbacks that interact with the JS context can detect its destruction. Currently, ScriptContext implements gin::Runner but is not immediately destroyed when the JS context is. This CL moves this gin::Runner implementation into a separate class which is destroyed when the ScriptContext is invalidated. Committed: https://crrev.com/de54a47ebf037458201dd5a36af885f078a8c861 Cr-Commit-Position: refs/heads/master@{#311358}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -31 lines) Patch
M extensions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/module_system_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/script_context.h View 4 chunks +5 lines, -10 lines 0 comments Download
M extensions/renderer/script_context.cc View 6 chunks +42 lines, -19 lines 0 comments Download
A extensions/renderer/script_context_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sam McNally
5 years, 11 months ago (2015-01-13 05:01:30 UTC) #5
not at google - send to devlin
lgtm
5 years, 11 months ago (2015-01-13 20:21:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831423005/60001
5 years, 11 months ago (2015-01-13 22:49:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 11 months ago (2015-01-13 23:17:05 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 23:17:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de54a47ebf037458201dd5a36af885f078a8c861
Cr-Commit-Position: refs/heads/master@{#311358}

Powered by Google App Engine
This is Rietveld 408576698