extensions/renderer/module_system_test.cc - Issue 831423005: Split out the extensions gin::Runner implementation into a separate class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/module_system_test.cc

Issue 831423005: Split out the extensions gin::Runner implementation into a separate class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/module_system_test.cc

diff --git a/extensions/renderer/module_system_test.cc b/extensions/renderer/module_system_test.cc

index fb197fce2f7ef7254afadd3f3220101940005e03..b9d4a4d8f3a31e36ee89e803755a34f75d3a5e03 100644

--- a/extensions/renderer/module_system_test.cc

+++ b/extensions/renderer/module_system_test.cc

@@ -156,7 +156,7 @@ ModuleSystemTestEnvironment::ModuleSystemTestEnvironment(v8::Isolate* isolate)

}

ModuleSystemTestEnvironment::~ModuleSystemTestEnvironment() {

- if (context_)

+ if (context_->is_valid())

context_->v8_context()->Exit();

}

@@ -197,7 +197,7 @@ void ModuleSystemTestEnvironment::ShutdownGin() {

void ModuleSystemTestEnvironment::ShutdownModuleSystem() {

context_->v8_context()->Exit();

- context_.reset();

+ context_->Invalidate();

}

v8::Handle<v8::Object> ModuleSystemTestEnvironment::CreateGlobal(

« no previous file with comments | « extensions/extensions.gyp ('k') | extensions/renderer/script_context.h » ('j') | no next file with comments »