sandbox/win/src/sharedmem_ipc_server.cc - Issue 831423002: Fix sandbox IPC shared memory leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/sharedmem_ipc_server.cc

Issue 831423002: Fix sandbox IPC shared memory leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/win/src/sharedmem_ipc_server.cc

diff --git a/sandbox/win/src/sharedmem_ipc_server.cc b/sandbox/win/src/sharedmem_ipc_server.cc

index 3b5fe6c2d3a6700cec8c8d98aa51a9b84ba1db85..af8ea46b4925e8815c2b8a834bcd4975dd1ae688 100644

--- a/sandbox/win/src/sharedmem_ipc_server.cc

+++ b/sandbox/win/src/sharedmem_ipc_server.cc

@@ -59,6 +59,9 @@ SharedMemIPCServer::~SharedMemIPCServer() {

::CloseHandle(context->pong_event);

delete context;

}

+ if (client_control_)

+ UnmapViewOfFile(client_control_);

rvargas (doing something else) 2015/01/06 02:57:34 nit: This code is using :: for OS functions.

}

bool SharedMemIPCServer::Init(void* shared_mem, uint32 shared_size,

« no previous file with comments | « no previous file | no next file » | no next file with comments »