Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 831423002: Fix sandbox IPC shared memory leak. (Closed)

Created:
5 years, 11 months ago by jbauman
Modified:
5 years, 11 months ago
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix sandbox IPC shared memory leak. This was leaking 64KB for every sandboxed process that exitted. BUG=445669 Committed: https://crrev.com/b533d6533585377edd63ec6500469f6c4fba602a Cr-Commit-Position: refs/heads/master@{#310201}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sandbox/win/src/sharedmem_ipc_server.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
5 years, 11 months ago (2015-01-06 01:35:32 UTC) #2
rvargas (doing something else)
LGTM (after nit), thanks!. https://codereview.chromium.org/831423002/diff/1/sandbox/win/src/sharedmem_ipc_server.cc File sandbox/win/src/sharedmem_ipc_server.cc (right): https://codereview.chromium.org/831423002/diff/1/sandbox/win/src/sharedmem_ipc_server.cc#newcode64 sandbox/win/src/sharedmem_ipc_server.cc:64: UnmapViewOfFile(client_control_); nit: This code is ...
5 years, 11 months ago (2015-01-06 02:57:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831423002/20001
5 years, 11 months ago (2015-01-07 00:08:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 01:11:04 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 01:12:08 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b533d6533585377edd63ec6500469f6c4fba602a
Cr-Commit-Position: refs/heads/master@{#310201}

Powered by Google App Engine
This is Rietveld 408576698