Add Robolectric build and license files to third_party.

Add Robolectric build and license files to third_party.

BUG=448030
Committed: https://crrev.com/5ae30e103f9e8a6a50ea295227b70f43697f7cf7
Cr-Commit-Position: refs/heads/master@{#317110}

[mikecase (-- gone --), 2015-01-06 23:33:53]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org

[mikecase (-- gone --), 2015-01-06 23:33:54]

Pretty sure I will have to write a custom test runner (similar to the
GoogleRobolectricTestRunner.java) but I'll do that after I get this in.
Also, unsure about what to put for URL in the README.chromium file. Should I
link the Git repo, or the location I downloaded the jar from
(http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.robolectric%22)

I sent to email to OSPO to get their approval.

Only problem I see with having prebuilt jars is that they are kinda large (the
android one is more than 50 MB).

[jbudorick, 2015-01-06 23:55:45]

You will definitely need to add something that doesn't hit Maven every time it
runs.

https://codereview.chromium.org/831173005/diff/20001/third_party/robolectric/...
File third_party/robolectric/README.chromium (right):

https://codereview.chromium.org/831173005/diff/20001/third_party/robolectric/...
third_party/robolectric/README.chromium:2: URL:
https://github.com/robolectric/robolectric.git
I would probably just list http://robolectric.org/

[mikecase (-- gone --), 2015-01-06 23:59:46]

mikecase@chromium.org changed reviewers:
+ klundberg@chromium.org

[mikecase (-- gone --), 2015-01-06 23:59:47]

Got an LGTM from OSPO via email.

[jbudorick, 2015-01-12 14:07:13]

jbudorick@chromium.org changed reviewers:
+ cjhopman@chromium.org

[jbudorick, 2015-01-12 14:07:14]

+cjhopman for gyp + gn

https://codereview.chromium.org/831173005/diff/20001/third_party/robolectric/...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/831173005/diff/20001/third_party/robolectric/...
third_party/robolectric/BUILD.gn:8: java_prebuilt("android_all_java") {
should this be testonly too?

[cjhopman, 2015-01-12 18:53:17]

On 2015/01/06 23:33:54, mikecase wrote:
> Pretty sure I will have to write a custom test runner (similar to the
> GoogleRobolectricTestRunner.java) but I'll do that after I get this in.
> Also, unsure about what to put for URL in the README.chromium file. Should I
> link the Git repo, or the location I downloaded the jar from
> (http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.robolectric%22)
> 
> I sent to email to OSPO to get their approval.
> 
> Only problem I see with having prebuilt jars is that they are kinda large (the
> android one is more than 50 MB).

50MB is pretty big for a jar, we probably want this in a separate repo. I'd talk
to infra about what they think.

[cjhopman, 2015-01-12 18:53:24]

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
third_party/robolectric/BUILD.gn:15: jar_path =
"lib/robolectric-2.4-jar-with-dependencies.jar"
What is in this jar?

Looking at
https://repo1.maven.org/maven2/org/robolectric/robolectric/2.4/robolectric-2....
I would expect android-all to already be in here.

I don't know that we really want to use this jar that packages all the
dependencies. We might be better off getting all the individual ones. I guess I
have two main concerns:

1. We shouldn't have two versions of a particularly library (e.g. junit) in a
dependency graph of a java target. If all of the different libraries in this jar
are things that we almost certainly won't use, then that's not really a big deal
(though I would definitely list them somewhere).

2. Does the licence in //third_party/robolectric/LICENSE actually cover this
jar? Or does it only cover the robolectric part of the jar?

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
File third_party/robolectric/README.chromium (right):

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
third_party/robolectric/README.chromium:8: Description: Robolectric is a unit
test framework for Android.
Could you add here something about where these jars came from/how to update
them?

[mikecase (-- gone --), 2015-01-13 18:36:20]

https://codereview.chromium.org/831173005/diff/20001/third_party/robolectric/...
File third_party/robolectric/README.chromium (right):

https://codereview.chromium.org/831173005/diff/20001/third_party/robolectric/...
third_party/robolectric/README.chromium:2: URL:
https://github.com/robolectric/robolectric.git
On 2015/01/06 23:55:44, jbudorick wrote:
> I would probably just list http://robolectric.org/

Done.

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
third_party/robolectric/BUILD.gn:15: jar_path =
"lib/robolectric-2.4-jar-with-dependencies.jar"
I tried using Robolectric without the android-all jar and it instantly
complained about not being able to find Application.class (which is an Android
class). Not all of the Android code robolectric needs is included in the
robolectric jar. This is talked about here...
http://robolectric.org/android-jars/
Don't know if we have the needed Android code already in Chromium.

To answer you questions.

1. Well, it appears that Junit and Mockito are not included in
robolectric-2.4-jar-with-dependencies.jar so we won't have 2 copies of those at
least. There are lots of other libraries included in the jar though including
code from...

http://nekohtml.sourceforge.net/
 - xercesMinimal:jar:1.9.6.2
 - nekohtml:jar:1.9.6.2
http://www.apache.org/
 - Lots of Maven jars
http://www.codehaus.org/
 - classworlds:jar:1.1-alpha-2
 - plexus-container-default:jar:1.0-alpha-9-stable-1
http://backport-jsr166.sourceforge.net/
 - backport-util-concurrent:jar:3.1
http://code.google.com/p/sqlite4java
 - sqlite-jdbc:jar:3.7.2
http://objenesis.org
 -  objenesis:jar:1.0
http://asm.ow2.org/
 - asm:jar:4.1
http://javolution.org
 - javolution:jar:5.5.1

Most of this code appears new, I do see a thirdparty/sqlite however.

2. It only covered the robolectric part of this jar.
To fix this I replaced the LICENSE file with a licenses/ directory which I put
the rest of the license files that were included in the jar. However, with all
the license files together in one directory (which is what the robolectric
people had) its not entirely clear what code falls under what license. I don't
know if I have to specify that.

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
File third_party/robolectric/README.chromium (right):

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
third_party/robolectric/README.chromium:8: Description: Robolectric is a unit
test framework for Android.
On 2015/01/12 18:53:23, cjhopman wrote:
> Could you add here something about where these jars came from/how to update
> them?

Done.

[jbudorick, 2015-01-13 18:42:39]

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
third_party/robolectric/BUILD.gn:15: jar_path =
"lib/robolectric-2.4-jar-with-dependencies.jar"
On 2015/01/13 18:36:20, mikecase wrote:
> I tried using Robolectric without the android-all jar and it instantly
> complained about not being able to find Application.class (which is an Android
> class). Not all of the Android code robolectric needs is included in the
> robolectric jar. This is talked about here...
> http://robolectric.org/android-jars/
> Don't know if we have the needed Android code already in Chromium.

I would be extremely surprised if we do. IIRC the android jars in the SDK only
contain method stubs. Robolectric needs the full implementations.

> 
> To answer you questions.
> 
> 1. Well, it appears that Junit and Mockito are not included in
> robolectric-2.4-jar-with-dependencies.jar so we won't have 2 copies of those
at
> least. There are lots of other libraries included in the jar though including
> code from...
> 
> http://nekohtml.sourceforge.net/
>  - xercesMinimal:jar:1.9.6.2
>  - nekohtml:jar:1.9.6.2
> http://www.apache.org/
>  - Lots of Maven jars
> http://www.codehaus.org/
>  - classworlds:jar:1.1-alpha-2
>  - plexus-container-default:jar:1.0-alpha-9-stable-1
> http://backport-jsr166.sourceforge.net/
>  - backport-util-concurrent:jar:3.1
> http://code.google.com/p/sqlite4java
>  - sqlite-jdbc:jar:3.7.2
> http://objenesis.org
>  -  objenesis:jar:1.0
> http://asm.ow2.org/
>  - asm:jar:4.1
> http://javolution.org
>  - javolution:jar:5.5.1
> 
> Most of this code appears new, I do see a thirdparty/sqlite however.
> 
> 2. It only covered the robolectric part of this jar.
> To fix this I replaced the LICENSE file with a licenses/ directory which I put
> the rest of the license files that were included in the jar. However, with all
> the license files together in one directory (which is what the robolectric
> people had) its not entirely clear what code falls under what license. I don't
> know if I have to specify that.

this sounds like an OSPO question

[cjhopman, 2015-01-13 21:26:19]

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/831173005/diff/40001/third_party/robolectric/...
third_party/robolectric/BUILD.gn:15: jar_path =
"lib/robolectric-2.4-jar-with-dependencies.jar"
On 2015/01/13 18:42:39, jbudorick wrote:
> On 2015/01/13 18:36:20, mikecase wrote:
> > I tried using Robolectric without the android-all jar and it instantly
> > complained about not being able to find Application.class (which is an
Android
> > class). Not all of the Android code robolectric needs is included in the
> > robolectric jar. This is talked about here...
> > http://robolectric.org/android-jars/
> > Don't know if we have the needed Android code already in Chromium.
> 
> I would be extremely surprised if we do. IIRC the android jars in the SDK only
> contain method stubs. Robolectric needs the full implementations.
> 
> > 
> > To answer you questions.
> > 
> > 1. Well, it appears that Junit and Mockito are not included in
> > robolectric-2.4-jar-with-dependencies.jar so we won't have 2 copies of those
> at
> > least. There are lots of other libraries included in the jar though
including
> > code from...
> > 
> > http://nekohtml.sourceforge.net/
> >  - xercesMinimal:jar:1.9.6.2
> >  - nekohtml:jar:1.9.6.2
> > http://www.apache.org/
> >  - Lots of Maven jars
> > http://www.codehaus.org/
> >  - classworlds:jar:1.1-alpha-2
> >  - plexus-container-default:jar:1.0-alpha-9-stable-1
> > http://backport-jsr166.sourceforge.net/
> >  - backport-util-concurrent:jar:3.1
> > http://code.google.com/p/sqlite4java
> >  - sqlite-jdbc:jar:3.7.2
> > http://objenesis.org
> >  -  objenesis:jar:1.0
> > http://asm.ow2.org/
> >  - asm:jar:4.1
> > http://javolution.org
> >  - javolution:jar:5.5.1
> > 
> > Most of this code appears new, I do see a thirdparty/sqlite however.
> > 
> > 2. It only covered the robolectric part of this jar.
> > To fix this I replaced the LICENSE file with a licenses/ directory which I
put
> > the rest of the license files that were included in the jar. However, with
all
> > the license files together in one directory (which is what the robolectric
> > people had) its not entirely clear what code falls under what license. I
don't
> > know if I have to specify that.
> 
> this sounds like an OSPO question

Yeah, sounds like an OSPO question. Also, we have automated processes and such
that expect a LICENSE file. Whatever we do needs to properly work with those
(there's checklicenses.py and webview_licenses.py and possibly whatever creates
the credits page and maybe other things). I don't know what the right way to do
this is, but I would be surprised if it isn't supported in some way.

https://codereview.chromium.org/831173005/diff/60001/third_party/robolectric/...
File third_party/robolectric/README.chromium (right):

https://codereview.chromium.org/831173005/diff/60001/third_party/robolectric/...
third_party/robolectric/README.chromium:4: License: MIT
This isn't correct. I don't know what you should put here with all the different
licenses that cover parts of this directory.

[cjhopman, 2015-01-13 21:36:00]

https://codereview.chromium.org/831173005/diff/60001/third_party/robolectric/...
File third_party/robolectric/README.chromium (right):

https://codereview.chromium.org/831173005/diff/60001/third_party/robolectric/...
third_party/robolectric/README.chromium:4: License: MIT
On 2015/01/13 21:26:19, cjhopman wrote:
> This isn't correct. I don't know what you should put here with all the
different
> licenses that cover parts of this directory.

Actually, I should clarify. This could be correct.

It is possible (depending on what the licenses actually require) that this
entire thing can be covered under just the MIT license, but it's complicated.

Taking a quick look at the license files, I believe the package can be
distributed with an Apache v2 license, but I'd talk with someone who knows
better.

[mikecase (-- gone --), 2015-01-20 22:43:48]

mikecase@chromium.org changed reviewers:
+ open-source-third-party-reviews@google.com

[mikecase (-- gone --), 2015-01-20 22:43:48]

Adding OSTPR to make sure I got the licenses right.

Want to robolectric-2.4-jar-with-dependencies.jar to Chromium which includes a
bunch of different libraries with difference licenses. Inside this jar is a main
/LICENSE.txt file (which is the Apache 2.0 license), and then a /license/
directory with some additional license files (extreme.indiana.edu.license.txt
and javolution.license.txt).

The robolectric code is covered under the MIT License which ins't included in
the prebuilt jar (I don't know why) but is included in the source jars they
have. So I added that license file to this CL.

The way Chromium src/thirdparty/ is setup, I think I need 1 main license file
that this jar falls under (to put in the README.chromium file). Can I put
"Apache 2.0" for this? Should I be ok if I just include all the license files
from the jar and the MIT license from the robolectric source? Thanks OSTPR

[mikecase (-- gone --), 2015-01-22 21:42:04]

mikecase@chromium.org changed reviewers:
+ navabi@chromium.org

[mikecase (-- gone --), 2015-01-22 21:42:05]

+navabi

Adding infra. Want to make sure its ok I commit the robolectric prebuilt jars to
thirdparty/. The robolectric jar is about 8 MB and it also depends on a 41 MB
android jar.

cjhopman suggested that it might be best to set up a repo to put these in. What
are your thoughts, are they too big to put directly into Chromium?

[mikecase (-- gone --), 2015-01-26 20:23:39]

The default Robolectric test runner will download json-20080701.jar,
tagsoup-1.2.jar, and android-all-4.3_r2-robolectric-0.jar from Maven at runtime.
Will need to have these jars in Chromium so that we don't have to get them from
Maven. Already had android-all, and just added json-20080701.jar and
tagsoup-1.2.jar to this CL.

[chromium-reviews, 2015-01-26 20:24:05]

LGTM for OSTPR

On Tue Jan 20 2015 at 2:43:49 PM <mikecase@chromium.org> wrote:

> Adding OSTPR to make sure I got the licenses right.
>
> Want to robolectric-2.4-jar-with-dependencies.jar to Chromium which
> includes a
> bunch of different libraries with difference licenses. Inside this jar is a
> main
> /LICENSE.txt file (which is the Apache 2.0 license), and then a /license/
> directory with some additional license files
> (extreme.indiana.edu.license.txt
> and javolution.license.txt).
>
> The robolectric code is covered under the MIT License which ins't included
> in
> the prebuilt jar (I don't know why) but is included in the source jars they
> have. So I added that license file to this CL.
>
> The way Chromium src/thirdparty/ is setup, I think I need 1 main license
> file
> that this jar falls under (to put in the README.chromium file). Can I put
> "Apache 2.0" for this? Should I be ok if I just include all the license
> files
> from the jar and the MIT license from the robolectric source? Thanks OSTPR
>
>
> https://codereview.chromium.org/831173005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cjhopman, 2015-01-26 22:14:06]

lgtm

https://codereview.chromium.org/831173005/diff/120001/third_party/robolectric...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/831173005/diff/120001/third_party/robolectric...
third_party/robolectric/BUILD.gn:8: java_prebuilt("android_all_java") {
add to all but robolectric:

visibility = [ ":*" ]

[mikecase (-- gone --), 2015-01-29 19:30:16]

pinging navabi.

Any comment on whether we will want to set up a repo to put the robolectric
jars. It seems like at some point we may need a couple
android-all-X.X_XX-robolectric-0.jar's to support multiple API levels, and each
of these jars is 40-50 MB.

[navabi, 2015-02-10 07:06:21]

navabi@google.com changed reviewers:
+ navabi@google.com

[navabi, 2015-02-10 07:06:22]

Sorry for the delay. I was on a recruiting trip last week.

I talked to Mike and decided this should be a separate repo that is only checked
out as part of the android checkout.

I'll get on that. Adding vadimsh who can create the repo, and I'll file a bug
for this.

[navabi, 2015-02-10 07:06:41]

navabi@google.com changed reviewers:
+ vadimsh@chromium.org

[navabi, 2015-02-10 20:57:42]

On 2015/02/10 07:06:41, navabi wrote:

See discussion here: https://code.google.com/p/chromium/issues/detail?id=457363

[mikecase (-- gone --), 2015-02-12 00:22:57]

Here is the commit being checked out via DEPS. Its just the initial commit
containing all of the necessary jar files.

https://chromium.googlesource.com/chromium/third_party/robolectric.git/+/6b63...

[navabi, 2015-02-12 20:15:21]

lgtm

[navabi1, 2015-02-12 20:16:06]

lgtm

[jbudorick, 2015-02-12 20:20:24]

lgtm

[cjhopman, 2015-02-12 22:27:17]

still lgtm

[mikecase (-- gone --), 2015-02-12 22:52:53]

mikecase@chromium.org changed reviewers:
+ cpu@chromium.org

[mikecase (-- gone --), 2015-02-12 22:52:54]

+cpu for DEPS and third_party/ review.

[cpu_(ooo_6.6-7.5), 2015-02-13 21:03:40]

please add a bug number to the CL description. I suggest you make a new bug
where you tell us why we need this, what it does. ELI5.

link this
https://code.google.com/p/chromium/issues/detail?id=457363

to the bug as well.

second, is this really pulling another sqlite source into the repo?

[cpu_(ooo_6.6-7.5), 2015-02-13 21:04:36]

also this assumes you did the steps in
http://www.chromium.org/developers/adding-3rd-party-libraries

[mikecase (-- gone --), 2015-02-17 21:58:35]

New patchsets have been uploaded after l-g-t-m from
navabi@google.com,navabi@chromium.org,jbudorick@chromium.org,cjhopman@chromiu...

[mikecase (-- gone --), 2015-02-17 22:13:36]

- Added the bug number to the CL description and updated the bug.

- I have done everything in
http://www.chromium.org/developers/adding-3rd-party-libraries

- And yes, the Robolectric prebuilt jar contains sqlite4java (a java wrapper for
sqlite). But I don't know how to avoid adding this.

[cpu_(ooo_6.6-7.5), 2015-02-18 15:58:11]

lgtm

[klundberg, 2015-02-18 17:41:05]

LGTM with minor nits

https://codereview.chromium.org/831173005/diff/200001/third_party/robolectric...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/831173005/diff/200001/third_party/robolectric...
third_party/robolectric/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All
rights reserved.
nit: it is now 2015 :-)

https://codereview.chromium.org/831173005/diff/200001/third_party/robolectric...
File third_party/robolectric/robolectric.gyp (right):

https://codereview.chromium.org/831173005/diff/200001/third_party/robolectric...
third_party/robolectric/robolectric.gyp:1: # Copyright 2014 The Chromium
Authors. All rights reserved.
nit: 2015

[mikecase (-- gone --), 2015-02-19 17:42:06]

New patchsets have been uploaded after l-g-t-m from
cpu@chromium.org,klundberg@chromium.org

[mikecase (-- gone --), 2015-02-19 17:42:28]

https://codereview.chromium.org/831173005/diff/200001/third_party/robolectric...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/831173005/diff/200001/third_party/robolectric...
third_party/robolectric/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All
rights reserved.
On 2015/02/18 17:41:04, klundberg wrote:
> nit: it is now 2015 :-)

Done.

https://codereview.chromium.org/831173005/diff/200001/third_party/robolectric...
File third_party/robolectric/robolectric.gyp (right):

https://codereview.chromium.org/831173005/diff/200001/third_party/robolectric...
third_party/robolectric/robolectric.gyp:1: # Copyright 2014 The Chromium
Authors. All rights reserved.
On 2015/02/18 17:41:04, klundberg wrote:
> nit: 2015

Done.

[mikecase (-- gone --), 2015-02-19 17:42:44]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-02-19 17:43:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/831173005/220001

[commit-bot: I haz the power, 2015-02-19 19:50:11]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-02-19 19:51:24]

Patchset 12 (id:??) landed as
https://crrev.com/5ae30e103f9e8a6a50ea295227b70f43697f7cf7
Cr-Commit-Position: refs/heads/master@{#317110}