Add Robolectric build and license files to third_party.

third_party/robolectric/BUILD.gn

+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//build/config/android/rules.gni")
+
+# GYP: //third_party/robolectric/robolectric.gyp:android_all_jar
+java_prebuilt("android_all_java") {
+  jar_path = "lib/android-all-5.0.0_r2-robolectric-0.jar"
+}
+
+# GYP: //third_party/robolectric/robolectric.gyp:robolectric_jar
+java_prebuilt("robolectric_java") {
+  testonly = true
+  jar_path = "lib/robolectric-2.4-jar-with-dependencies.jar"

[cjhopman, 2015/01/12 18:53:23]

What is in this jar?

Looking at
https://repo1.maven.org/maven2/org/robolectric/robolectric/2.4/robolectric-2....
I would expect android-all to already be in here.

I don't know that we really want to use this jar that packages all the
dependencies. We might be better off getting all the individual ones. I guess I
have two main concerns:

1. We shouldn't have two versions of a particularly library (e.g. junit) in a
dependency graph of a java target. If all of the different libraries in this jar
are things that we almost certainly won't use, then that's not really a big deal
(though I would definitely list them somewhere).

2. Does the licence in //third_party/robolectric/LICENSE actually cover this
jar? Or does it only cover the robolectric part of the jar?

[mikecase (-- gone --), 2015/01/13 18:36:20]

I tried using Robolectric without the android-all jar and it instantly
complained about not being able to find Application.class (which is an Android
class). Not all of the Android code robolectric needs is included in the
robolectric jar. This is talked about here...
http://robolectric.org/android-jars/
Don't know if we have the needed Android code already in Chromium.

To answer you questions.

1. Well, it appears that Junit and Mockito are not included in
robolectric-2.4-jar-with-dependencies.jar so we won't have 2 copies of those at
least. There are lots of other libraries included in the jar though including
code from...

http://nekohtml.sourceforge.net/
 - xercesMinimal:jar:1.9.6.2
 - nekohtml:jar:1.9.6.2
http://www.apache.org/
 - Lots of Maven jars
http://www.codehaus.org/
 - classworlds:jar:1.1-alpha-2
 - plexus-container-default:jar:1.0-alpha-9-stable-1
http://backport-jsr166.sourceforge.net/
 - backport-util-concurrent:jar:3.1
http://code.google.com/p/sqlite4java
 - sqlite-jdbc:jar:3.7.2
http://objenesis.org
 -  objenesis:jar:1.0
http://asm.ow2.org/
 - asm:jar:4.1
http://javolution.org
 - javolution:jar:5.5.1

Most of this code appears new, I do see a thirdparty/sqlite however.

2. It only covered the robolectric part of this jar.
To fix this I replaced the LICENSE file with a licenses/ directory which I put
the rest of the license files that were included in the jar. However, with all
the license files together in one directory (which is what the robolectric
people had) its not entirely clear what code falls under what license. I don't
know if I have to specify that.

[jbudorick, 2015/01/13 18:42:39]

I would be extremely surprised if we do. IIRC the android jars in the SDK only
contain method stubs. Robolectric needs the full implementations.
this sounds like an OSPO question

[cjhopman, 2015/01/13 21:26:19]

Yeah, sounds like an OSPO question. Also, we have automated processes and such
that expect a LICENSE file. Whatever we do needs to properly work with those
(there's checklicenses.py and webview_licenses.py and possibly whatever creates
the credits page and maybe other things). I don't know what the right way to do
this is, but I would be surprised if it isn't supported in some way.

+  deps = [
+    ":android_all_java",
+  ]
+}