Close embedded extension options page when the overlay is hidden

Close embedded extension options page when the overlay is hidden

Previously, when the embedded extension options page was hidden through
an unexpected event (i.e. not via Esc or via the Close button, but via
a script, e.g. by bug 445918), the extension options page would not be
removed even though it was hidden.

This patch fixes the problem by triggering the page destruction handlers
(ExtensionOptionsOverlay.prototype.handleDismiss_) via the cancelOverlay
event.

BUG=445978
R=finnur@chromium.org

Committed: https://crrev.com/5eefc8b5665c30573bddfec1cecd561e57f60823
Cr-Commit-Position: refs/heads/master@{#310763}

[Finnur, 2015-01-05 10:07:26]

https://codereview.chromium.org/831063002/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extensions.js (right):

https://codereview.chromium.org/831063002/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extensions.js:409:
cr.dispatchSimpleEvent($('overlay'), 'cancelOverlay');
The bug states that the overlay erroneously closes. I don't see how manually
closing it here fixes the issue...?

[robwu, 2015-01-05 10:14:29]

https://codereview.chromium.org/831063002/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extensions.js (right):

https://codereview.chromium.org/831063002/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extensions.js:409:
cr.dispatchSimpleEvent($('overlay'), 'cancelOverlay');
On 2015/01/05 10:07:26, Finnur wrote:
> The bug states that the overlay erroneously closes. I don't see how manually
> closing it here fixes the issue...?

Oops, wrong bug number. It is crbug.com/445978.

[robwu, 2015-01-05 10:24:02]

On 2015/01/05 10:14:29, robwu wrote:
>
https://codereview.chromium.org/831063002/diff/1/chrome/browser/resources/ext...
> File chrome/browser/resources/extensions/extensions.js (right):
> 
>
https://codereview.chromium.org/831063002/diff/1/chrome/browser/resources/ext...
> chrome/browser/resources/extensions/extensions.js:409:
> cr.dispatchSimpleEvent($('overlay'), 'cancelOverlay');
> On 2015/01/05 10:07:26, Finnur wrote:
> > The bug states that the overlay erroneously closes. I don't see how manually
> > closing it here fixes the issue...?
> 
> Oops, wrong bug number. It is crbug.com/445978.

This CL does not fix the root cause of linked bug (presumably a bad
implementaiton of <extensionoptions>), by the way. It only prevents the bug from
happening by removing <extensionoptions> when the overlay ought to be closed.

[robwu, 2015-01-08 16:49:42]

Ping @Finnur

[Finnur, 2015-01-09 11:28:32]

Sorry to keep you waiting. For some reason I did not see that you had replied.

LGTM.

[robwu, 2015-01-09 11:31:56]

The CQ bit was checked by rob@robwu.nl

[commit-bot: I haz the power, 2015-01-09 11:33:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/831063002/1

[commit-bot: I haz the power, 2015-01-09 12:39:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-09 12:40:10]

Patchset 1 (id:??) landed as
https://crrev.com/5eefc8b5665c30573bddfec1cecd561e57f60823
Cr-Commit-Position: refs/heads/master@{#310763}