chrome/browser/resources/extensions/extensions.js - Issue 831063002: Close embedded extension options page when the overlay is hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 831063002: Close embedded extension options page when the overlay is hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/extensions/extensions.js

diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js

index 42ad4a43770de5e296f5dc28ba144450b24e6dff..f80a2997cb5f18abf63926c9d63fb2e039640e75 100644

--- a/chrome/browser/resources/extensions/extensions.js

+++ b/chrome/browser/resources/extensions/extensions.js

@@ -404,8 +404,10 @@ cr.define('extensions', function() {

}

var currentlyShowingOverlay = ExtensionSettings.getCurrentOverlay();

- if (currentlyShowingOverlay)

+ if (currentlyShowingOverlay) {

currentlyShowingOverlay.classList.remove('showing');

+ cr.dispatchSimpleEvent($('overlay'), 'cancelOverlay');

Finnur 2015/01/05 10:07:26 The bug states that the overlay erroneously closes

robwu 2015/01/05 10:14:29 Oops, wrong bug number. It is crbug.com/445978.

+ }

if (node)

node.classList.add('showing');

« no previous file with comments | « no previous file | no next file » | no next file with comments »