Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 8308008: mac: Fix a memory leak in canvas_skia_mac. (Closed)

Created:
9 years, 2 months ago by Nico
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

mac: Fix a memory leak in canvas_skia_mac. Found by the clang static analyzer: ui/gfx/canvas_skia_mac.mm:70:27: warning: Potential leak of an object allocated on line 70 and stored into 'path' CGMutablePathRef path = CGPathCreateMutable(); ^ 1 warning generated. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gfx/canvas_skia_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
9 years, 2 months ago (2011-10-16 05:35:22 UTC) #1
Mark Mentovai
LGTM
9 years, 2 months ago (2011-10-16 15:22:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8308008/1
9 years, 2 months ago (2011-10-16 15:48:04 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-16 17:33:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8308008/1
9 years, 2 months ago (2011-10-16 18:33:37 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-16 23:17:27 UTC) #6
Change committed as 105751

Powered by Google App Engine
This is Rietveld 408576698