Add gyp file to build apple_sample_code.

Add gyp file to build apple_sample_code.

This is a step forward on removing ui_cocoa_third_party_toolkits target
from ui.gyp.

BUG=299841
TEST=None
R=tapted@chromium.org,ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238215

[tfarina, 2013-11-23 01:48:51]

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
File third_party/apple_sample_code/apple_sample_code.gyp (right):

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
third_party/apple_sample_code/apple_sample_code.gyp:15:
'$(SDKROOT)/System/Library/Frameworks/AppKit.framework',
Trent is this enough? I haven't tested at all (like I said I don't have a Mac).

[tapted, 2013-11-24 22:58:39]

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
File third_party/apple_sample_code/apple_sample_code.gyp (right):

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
third_party/apple_sample_code/apple_sample_code.gyp:12: 'type':
'static_library',
this should be '<(component)' I think

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
third_party/apple_sample_code/apple_sample_code.gyp:15:
'$(SDKROOT)/System/Library/Frameworks/AppKit.framework',
On 2013/11/23 01:48:51, tfarina wrote:
> Trent is this enough? I haven't tested at all (like I said I don't have a
Mac).

I'm not sure - it depends how the code is used. Objective C doesn't always break
at link time.

It looks like it's just used in
chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm

so I'd check with OWNERS there. You'll also want an owner from
third_party/apple_sample_code

[tfarina, 2013-11-24 23:07:14]

+OWNERS!

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
File third_party/apple_sample_code/apple_sample_code.gyp (right):

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
third_party/apple_sample_code/apple_sample_code.gyp:12: 'type':
'static_library',
On 2013/11/24 22:58:39, tapted wrote:
> this should be '<(component)' I think
I think that only works if we setup a _export.h file and tag the exported
symbols. hence I'm leaving as static_library.

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
third_party/apple_sample_code/apple_sample_code.gyp:15:
'$(SDKROOT)/System/Library/Frameworks/AppKit.framework',
On 2013/11/24 22:58:39, tapted wrote:
> On 2013/11/23 01:48:51, tfarina wrote:
> > Trent is this enough? I haven't tested at all (like I said I don't have a
> Mac).
> 
> I'm not sure - it depends how the code is used. Objective C doesn't always
break
> at link time.
> 
> It looks like it's just used in
> chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm
> 
+Jochen.

> so I'd check with OWNERS there. You'll also want an owner from
> third_party/apple_sample_code
+Avi.

[Avi (use Gerrit), 2013-11-25 00:31:43]

I will stamp, but I don't know about the intricacies of gyp files. Ask Mark.

[tfarina, 2013-11-25 00:44:35]

On 2013/11/25 00:31:43, Avi wrote:
> I will stamp, but I don't know about the intricacies of gyp files. Ask Mark.

Mark is what I have OK?

[Mark Mentovai, 2013-11-25 18:01:34]

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
File third_party/apple_sample_code/apple_sample_code.gyp (right):

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
third_party/apple_sample_code/apple_sample_code.gyp:1: # Copyright 2013 The
Chromium Authors. All rights reserved.
Can you adjust your similarity so that this does not show up as a file copy?

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
third_party/apple_sample_code/apple_sample_code.gyp:7: 'chromium_code': 1,
This is not chromium_code.

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
third_party/apple_sample_code/apple_sample_code.gyp:15:
'$(SDKROOT)/System/Library/Frameworks/AppKit.framework',
Yes, AppKit.framework is is enough.

[tfarina, 2013-11-29 22:42:51]

Mark, PTAL.

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
File third_party/apple_sample_code/apple_sample_code.gyp (right):

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
third_party/apple_sample_code/apple_sample_code.gyp:1: # Copyright 2013 The
Chromium Authors. All rights reserved.
On 2013/11/25 18:01:34, Mark Mentovai wrote:
> Can you adjust your similarity so that this does not show up as a file copy?

Done.

https://codereview.chromium.org/83073012/diff/1/third_party/apple_sample_code...
third_party/apple_sample_code/apple_sample_code.gyp:7: 'chromium_code': 1,
On 2013/11/25 18:01:34, Mark Mentovai wrote:
> This is not chromium_code.

Done.

[Mark Mentovai, 2013-11-29 23:19:43]

LGTM

[Ben Goodger (Google), 2013-12-02 18:58:26]

lgtm thanks!

[commit-bot: I haz the power, 2013-12-02 20:55:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/83073012/250001

[commit-bot: I haz the power, 2013-12-02 23:00:32]

Change committed as 238215