Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: third_party/apple_sample_code/apple_sample_code.gyp

Issue 83073012: Add gyp file to build apple_sample_code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | ui/ui.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
Mark Mentovai 2013/11/25 18:01:34 Can you adjust your similarity so that this does n
tfarina 2013/11/29 22:42:52 Done.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
Mark Mentovai 2013/11/25 18:01:34 This is not chromium_code.
tfarina 2013/11/29 22:42:52 Done.
8 }, 8 },
9 'targets': [ 9 'targets': [
10 { 10 {
11 'target_name': 'wm_test_support', 11 'target_name': 'apple_sample_code',
12 'type': 'static_library', 12 'type': 'static_library',
tapted 2013/11/24 22:58:39 this should be '<(component)' I think
tfarina 2013/11/24 23:07:15 I think that only works if we setup a _export.h fi
13 'dependencies': [ 13 'link_settings': {
14 '../../skia/skia.gyp:skia', 14 'libraries': [
15 '../aura/aura.gyp:aura', 15 '$(SDKROOT)/System/Library/Frameworks/AppKit.framework',
tfarina 2013/11/23 01:48:51 Trent is this enough? I haven't tested at all (lik
tapted 2013/11/24 22:58:39 I'm not sure - it depends how the code is used. Ob
tfarina 2013/11/24 23:07:15 +Jochen.
Mark Mentovai 2013/11/25 18:01:34 Yes, AppKit.framework is is enough.
16 '../views/views.gyp:views', 16 ],
17 ], 17 },
18 'sources': [ 18 'sources': [
19 'test/wm_test_helper.cc', 19 'ImageAndTextCell.h',
20 'test/wm_test_helper.h', 20 'ImageAndTextCell.m',
21 ], 21 ],
22 }, 22 },
23 ], 23 ],
24 } 24 }
OLDNEW
« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | ui/ui.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698