Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 83073006: Add "change" and "removetrack" events to TextTrackList. (Closed)

Created:
7 years, 1 month ago by Brendan Long
Modified:
7 years ago
CC:
blink-reviews, nessy, arv+blink, philipj_slow, gasubic, watchdog-blink-watchlist_google.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@add-track-id-again
Visibility:
Public.

Description

Add "change" and "removetrack" events to TextTrackList. I think this is trivial because it just adds more events to a new incomplete interface. W3C: http://www.w3.org/TR/html5/embedded-content-0.html#texttracklist WHATWG: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#texttracklist This is implemented (just now, by me) in WebKit: https://bugs.webkit.org/show_bug.cgi?id=124789 Firefox's bug tracker says they're planning to implement it: https://bugzilla.mozilla.org/show_bug.cgi?id=882703 BUG=315834 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162807

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove event scheduling code duplication and use GenericEventQueue #

Patch Set 3 : Fix test results for Opera onremovetrack test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -43 lines) Patch
M LayoutTests/media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/media/track/track-change-event.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/media/track/track-change-event-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/media/track/track-remove-track.html View 2 chunks +13 lines, -19 lines 0 comments Download
A LayoutTests/media/track/track-remove-track-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/track/TextTrackList.h View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M Source/core/html/track/TextTrackList.cpp View 1 2 5 chunks +40 lines, -17 lines 0 comments Download
M Source/core/html/track/TextTrackList.idl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
Brendan Long
7 years, 1 month ago (2013-11-22 18:51:12 UTC) #1
eseidel
Please add some explanation as to why this change doesn't need to go through normal ...
7 years, 1 month ago (2013-11-22 19:09:53 UTC) #2
Brendan Long
On 2013/11/22 19:09:53, eseidel wrote: > I presume you're arguing it as a trivial extension? ...
7 years, 1 month ago (2013-11-22 21:52:02 UTC) #3
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/83073006/diff/1/Source/core/html/track/TextTrackList.cpp File Source/core/html/track/TextTrackList.cpp (right): https://codereview.chromium.org/83073006/diff/1/Source/core/html/track/TextTrackList.cpp#newcode295 Source/core/html/track/TextTrackList.cpp:295: RefPtr<TrackBase> trackRef = track; nit: Please move this to ...
7 years, 1 month ago (2013-11-22 23:47:57 UTC) #4
Brendan Long
Added scheduleTrackEvent() and replaced event scheduling with a GenericEventQueue.
7 years, 1 month ago (2013-11-23 19:19:21 UTC) #5
acolwell GONE FROM CHROMIUM
lgtm
7 years ago (2013-11-25 19:25:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-27 04:15:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=11924
7 years ago (2013-11-27 04:31:04 UTC) #8
Brendan Long
On 2013/11/27 04:31:04, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years ago (2013-11-27 15:27:36 UTC) #9
acolwell GONE FROM CHROMIUM
On 2013/11/27 15:27:36, Brendan Long wrote: > On 2013/11/27 04:31:04, I haz the power (commit-bot) ...
7 years ago (2013-11-27 15:31:10 UTC) #10
Brendan Long
eseidel: Is there anything more you want done before merging this?
7 years ago (2013-11-27 21:29:16 UTC) #11
eseidel
lgtm
7 years ago (2013-11-28 00:16:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 01:13:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 01:57:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 02:03:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 02:06:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 02:17:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 02:22:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 02:23:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 02:25:58 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 02:43:44 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 02:47:15 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 02:52:55 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/80001
7 years ago (2013-11-28 02:56:43 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/self@brendanlong.com/83073006/190002
7 years ago (2013-11-28 03:44:05 UTC) #25
commit-bot: I haz the power
7 years ago (2013-11-28 05:25:25 UTC) #26
Message was sent while issue was closed. 
Change committed as 162807

Powered by Google App Engine
This is Rietveld 408576698