Update mojo sdk to rev 9fbbc4f0fef1187312316c0ed992342474e139f1

Update mojo sdk to rev 9fbbc4f0fef1187312316c0ed992342474e139f1

BUG=None
TBR=jamesr@chromium.org
TBR=darin@chromium.org

Committed: https://crrev.com/6dcbf7cdd88395e3719f79753976841762969e0b
Cr-Commit-Position: refs/heads/master@{#311784}

[Ken Rockot(use gerrit already), 2015-01-15 03:16:41]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-01-15 03:17:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/830593003/60001

[commit-bot: I haz the power, 2015-01-15 03:51:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 03:51:15]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Ken Rockot(use gerrit already), 2015-01-15 06:37:24]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-01-15 06:38:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/830593003/80001

[Ken Rockot(use gerrit already), 2015-01-15 06:44:25]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2015-01-15 06:44:35]

Patchset #5 (id:80001) has been deleted

[Ken Rockot(use gerrit already), 2015-01-15 07:37:15]

Patchset #5 (id:100001) has been deleted

[Ken Rockot(use gerrit already), 2015-01-15 18:04:09]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-01-15 18:05:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/830593003/120001

[commit-bot: I haz the power, 2015-01-15 19:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 19:18:23]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2015-01-15 21:55:39]

Anyone have any insight on the Win8 compile failures? I think they're the only
outstanding problem now, but A) I don't think this same patch was eliciting
these failures yesterday and B) I find it odd that no other Windows builders
have a problem with this code.

[jamesr, 2015-01-15 22:14:19]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2015-01-15 22:14:21]

[1273/4217] STAMP obj/ui/resources/ui_resources_grd_grit.inputdeps.stamp
FAILED: ninja -t msvc -e environment.x86 --
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
/showIncludes /FC
@obj/out/Release/gen/mojo/public/interfaces/bindings/tests/test_interfaces.test_unions.mojom.obj.rsp
/c gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.cc
/Foobj/out/Release/gen/mojo/public/interfaces/bindings/tests/test_interfaces.test_unions.mojom.obj
/Fdobj/mojo/public/interfaces/bindings/tests/test_interfaces_cc.pdb
e:\b\build\slave\win_gn\build\src\out\release\gen\mojo\public\interfaces\bindings\tests\test_unions.mojom.h(151)
:error C2621: 'mojo::test::PodUnion::Union_::f_string' : illegal union member;
type 'mojo::String' has a copy constructor
e:\b\build\slave\win_gn\build\src\out\release\gen\mojo\public\interfaces\bindings\tests\test_unions.mojom.cc(216)
:error C2039: 'f_string' : is not a member of 'mojo::test::PodUnion::Union_'


The union stuff is very new, azani@ has been poking at it.  It's surprising to
me that vs2013 on the win8 bot behaves differently from vs2013 on the win7 bot.

[jamesr, 2015-01-15 22:26:22]

Ah, probably the win8 gn trybot is the only gn trybot on windows and we only try
to run this particular target.  So the issue is just that this construct doesn't
work in the win8 toolchain.

Proper answer is probably to revert the patch that added this in mojo.

[jamesr, 2015-01-15 22:29:46]

Looks like
https://github.com/domokit/mojo/commit/c9946319b4a4f377f696f146304293a8329b3be5
added this.  I think the author is OOO for a bit

[Ken Rockot(use gerrit already), 2015-01-15 22:33:20]

On 2015/01/15 22:29:46, jamesr wrote:
> Looks like
>
https://github.com/domokit/mojo/commit/c9946319b4a4f377f696f146304293a8329b3be5
> added this.  I think the author is OOO for a bit

Yeah, and a revert looks a bit messy. WDYT about just omitting the union tests
from build?

[Ken Rockot(use gerrit already), 2015-01-15 22:34:50]

On 2015/01/15 22:33:20, Ken Rockot wrote:
> On 2015/01/15 22:29:46, jamesr wrote:
> > Looks like
> >
>
https://github.com/domokit/mojo/commit/c9946319b4a4f377f696f146304293a8329b3be5
> > added this.  I think the author is OOO for a bit
> 
> Yeah, and a revert looks a bit messy. WDYT about just omitting the union tests
> from build?

actually maybe not so bad. CL incoming

[Ken Rockot(use gerrit already), 2015-01-15 23:50:23]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-01-15 23:51:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/830593003/140001

[commit-bot: I haz the power, 2015-01-16 00:41:45]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2015-01-16 00:42:29]

Patchset 6 (id:??) landed as
https://crrev.com/6dcbf7cdd88395e3719f79753976841762969e0b
Cr-Commit-Position: refs/heads/master@{#311784}

[chromium-reviews, 2015-01-20 01:49:41]

Can I get a pointer to running the tests on the try bot before checkin?
On Jan 16, 2015 7:42 AM, <commit-bot@chromium.org> wrote:

> Patchset 6 (id:??) landed as
> https://crrev.com/6dcbf7cdd88395e3719f79753976841762969e0b
> Cr-Commit-Position: refs/heads/master@{#311784}
>
> https://codereview.chromium.org/830593003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blundell, 2015-01-20 07:46:13]

On 2015/01/20 01:49:41, chromium-reviews wrote:
> Can I get a pointer to running the tests on the try bot before checkin?

There's no straightforward way to run the Chromium trybots on a Mojo change
before checking the change into Mojo. The only sure-fire thing to do would be to
locally do a roll of Mojo into Chromium and then apply your change on top in
Chromium. Doing a Mojo roll in Chromium can be a lot of work.

> On Jan 16, 2015 7:42 AM, <mailto:commit-bot@chromium.org> wrote:
> 
> > Patchset 6 (id:??) landed as
> > https://crrev.com/6dcbf7cdd88395e3719f79753976841762969e0b
> > Cr-Commit-Position: refs/heads/master@{#311784}
> >
> > https://codereview.chromium.org/830593003/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2015-01-20 07:50:05]

The problem before was not specific to chromium AFAIK; rather it was an
incompatibility with VC 2013.

On Mon, Jan 19, 2015 at 11:46 PM, <blundell@chromium.org> wrote:

> On 2015/01/20 01:49:41, chromium-reviews wrote:
>
>> Can I get a pointer to running the tests on the try bot before checkin?
>>
>
> There's no straightforward way to run the Chromium trybots on a Mojo change
> before checking the change into Mojo. The only sure-fire thing to do would
> be to
> locally do a roll of Mojo into Chromium and then apply your change on top
> in
> Chromium. Doing a Mojo roll in Chromium can be a lot of work.
>
>  On Jan 16, 2015 7:42 AM, <mailto:commit-bot@chromium.org> wrote:
>>
>
>  > Patchset 6 (id:??) landed as
>> > https://crrev.com/6dcbf7cdd88395e3719f79753976841762969e0b
>> > Cr-Commit-Position: refs/heads/master@{#311784}
>> >
>> > https://codereview.chromium.org/830593003/
>> >
>>
>
>  To unsubscribe from this group and stop receiving emails from it, send an
>>
> email
>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
>
>
> https://codereview.chromium.org/830593003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2015-01-26 02:12:42]

You're right. It looks like Visual Studio does not support unrestricted
unions yet. :(

On Mon, Jan 19, 2015 at 11:50 PM, Ken Rockot <rockot@chromium.org> wrote:

> The problem before was not specific to chromium AFAIK; rather it was an
> incompatibility with VC 2013.
>
> On Mon, Jan 19, 2015 at 11:46 PM, <blundell@chromium.org> wrote:
>
>> On 2015/01/20 01:49:41, chromium-reviews wrote:
>>
>>> Can I get a pointer to running the tests on the try bot before checkin?
>>>
>>
>> There's no straightforward way to run the Chromium trybots on a Mojo
>> change
>> before checking the change into Mojo. The only sure-fire thing to do
>> would be to
>> locally do a roll of Mojo into Chromium and then apply your change on top
>> in
>> Chromium. Doing a Mojo roll in Chromium can be a lot of work.
>>
>>  On Jan 16, 2015 7:42 AM, <mailto:commit-bot@chromium.org> wrote:
>>>
>>
>>  > Patchset 6 (id:??) landed as
>>> > https://crrev.com/6dcbf7cdd88395e3719f79753976841762969e0b
>>> > Cr-Commit-Position: refs/heads/master@{#311784}
>>> >
>>> > https://codereview.chromium.org/830593003/
>>> >
>>>
>>
>>  To unsubscribe from this group and stop receiving emails from it, send an
>>>
>> email
>>
>>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>>
>>
>>
>>
>> https://codereview.chromium.org/830593003/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.