Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: mojo/edk/system/transport_data.h

Issue 830593003: Update mojo sdk to rev 9fbbc4f0fef1187312316c0ed992342474e139f1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cherry-pick mojo 9d3b8dd17f12d20035a14737fdc38dd926890ff8 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/test_utils.cc ('k') | mojo/edk/system/transport_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/transport_data.h
diff --git a/mojo/edk/system/transport_data.h b/mojo/edk/system/transport_data.h
index d54ad2ab2b19486e82aa98f241867ebbc9b3f9d2..1258f4935f9f70ad23576fd7a3396ebd994c08ba 100644
--- a/mojo/edk/system/transport_data.h
+++ b/mojo/edk/system/transport_data.h
@@ -91,15 +91,12 @@ class MOJO_SYSTEM_IMPL_EXPORT TransportData {
TransportData(scoped_ptr<DispatcherVector> dispatchers, Channel* channel);
-#if defined(OS_POSIX)
- // This is a hacky POSIX-only constructor to directly attach only platform
- // handles to a message, used by |RawChannelPosix| to split messages with too
- // many platform handles into multiple messages. |Header| will be present, but
- // be zero. (No other information will be attached, and
- // |RawChannel::GetSerializedPlatformHandleSize()| should return zero.)
+ // This is used for users of |MessageInTransit|/|TransportData|/|RawChannel|
+ // that want to simply transport data and platform handles, and not
+ // |Dispatcher|s. (|Header| will be present, and zero except for
+ // |num_platform_handles|, and |platform_handle_table_offset| if necessary.)
explicit TransportData(
embedder::ScopedPlatformHandleVectorPtr platform_handles);
-#endif
~TransportData();
@@ -180,7 +177,7 @@ class MOJO_SYSTEM_IMPL_EXPORT TransportData {
// Any platform-specific handles attached to this message (for inter-process
// transport). The vector (if any) owns the handles that it contains (and is
// responsible for closing them).
- // TODO(vtl): With C++11, change it to a vector of |ScopedPlatformHandles|.
+ // TODO(vtl): With C++11, change it to a vector of |ScopedPlatformHandle|s.
embedder::ScopedPlatformHandleVectorPtr platform_handles_;
DISALLOW_COPY_AND_ASSIGN(TransportData);
« no previous file with comments | « mojo/edk/system/test_utils.cc ('k') | mojo/edk/system/transport_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698