Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: src/IceCfg.cpp

Issue 830303003: Subzero: Clean up a few areas. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Rewrite another loop using reverse_range() Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceCfgNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCfg.cpp
diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp
index 9726ff92f876099bbb4a7b807185541eaba4fa4c..d3c47d4c8ea4f5f0e6ba80f94d06dd915d389d7d 100644
--- a/src/IceCfg.cpp
+++ b/src/IceCfg.cpp
@@ -269,8 +269,7 @@ void Cfg::liveness(LivenessMode Mode) {
llvm::BitVector NeedToProcess(Nodes.size(), true);
while (NeedToProcess.any()) {
// Iterate in reverse topological order to speed up convergence.
- for (auto I = Nodes.rbegin(), E = Nodes.rend(); I != E; ++I) {
- CfgNode *Node = *I;
+ for (CfgNode *Node : reverse_range(Nodes)) {
if (NeedToProcess[Node->getIndex()]) {
NeedToProcess[Node->getIndex()] = false;
bool Changed = Node->liveness(getLiveness());
@@ -442,16 +441,6 @@ void Cfg::emit() {
dump("After recomputing liveness for -decorate-asm");
}
Ostream &Str = Ctx->getStrEmit();
- if (!Ctx->testAndSetHasEmittedFirstMethod()) {
- // Print a helpful command for assembling the output.
- // TODO: have the Target emit the header
- // TODO: need a per-file emit in addition to per-CFG
- Str << "# $LLVM_BIN_PATH/llvm-mc"
- << " -arch=x86"
- << " -filetype=obj"
- << " -o=MyObj.o"
- << "\n\n";
- }
IceString MangledName = getContext()->mangleName(getFunctionName());
emitTextHeader(MangledName);
for (CfgNode *Node : Nodes)
« no previous file with comments | « no previous file | src/IceCfgNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698