Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 830273006: Delete document marker related invalidation code. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
CC:
abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete document marker related invalidation code. I believe this doesn't change behavior, but it's hard to know since we don't have spellchecking hooked up. Also, delete setToolTip. This is for tooltips on spelling markers. We don't support tooltips. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4237e96a4059caac9a46439e942f18831ebbd73d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -174 lines) Patch
M sky/engine/core/dom/DocumentMarkerController.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/DocumentMarkerController.cpp View 5 chunks +0 lines, -80 lines 0 comments Download
M sky/engine/core/dom/RenderedDocumentMarker.h View 2 chunks +3 lines, -22 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/Chrome.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/Chrome.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M sky/engine/core/page/ChromeClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/HitTestResult.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/HitTestResult.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M sky/engine/core/rendering/InlineTextBox.cpp View 2 chunks +2 lines, -20 lines 0 comments Download
M sky/engine/public/web/WebWidgetClient.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
5 years, 11 months ago (2015-01-17 03:50:50 UTC) #2
esprehn
On 2015/01/17 at 03:50:50, ojan wrote: > Lgtm
5 years, 11 months ago (2015-01-17 03:53:39 UTC) #3
ojan
5 years, 11 months ago (2015-01-17 04:01:07 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4237e96a4059caac9a46439e942f18831ebbd73d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698