Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1888)

Unified Diff: sky/engine/core/dom/RenderedDocumentMarker.h

Issue 830273006: Delete document marker related invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/DocumentMarkerController.cpp ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/RenderedDocumentMarker.h
diff --git a/sky/engine/core/dom/RenderedDocumentMarker.h b/sky/engine/core/dom/RenderedDocumentMarker.h
index 2e111ac13b2cf18acd817791f3599ff426257e12..a93e3b0d21c562d77e6975873a370c7bdab68258 100644
--- a/sky/engine/core/dom/RenderedDocumentMarker.h
+++ b/sky/engine/core/dom/RenderedDocumentMarker.h
@@ -32,6 +32,9 @@
namespace blink {
+// FIXME(sky): We no longer need this subclass. Remove it
+// and just used DocumentMarker.
+
class RenderedDocumentMarker final : public DocumentMarker {
public:
static PassOwnPtr<RenderedDocumentMarker> create(const DocumentMarker& marker)
@@ -39,35 +42,13 @@ public:
return adoptPtr(new RenderedDocumentMarker(marker));
}
- bool isRendered() const { return invalidMarkerRect() != m_renderedRect; }
- bool contains(const LayoutPoint& point) const { return isRendered() && m_renderedRect.contains(point); }
- void setRenderedRect(const LayoutRect& r) { m_renderedRect = r; }
- const LayoutRect& renderedRect() const { return m_renderedRect; }
- void invalidate(const LayoutRect&);
- void invalidate() { m_renderedRect = invalidMarkerRect(); }
-
private:
explicit RenderedDocumentMarker(const DocumentMarker& marker)
: DocumentMarker(marker)
- , m_renderedRect(invalidMarkerRect())
{
}
-
- static const LayoutRect& invalidMarkerRect()
- {
- static const LayoutRect rect = LayoutRect(-1, -1, -1, -1);
- return rect;
- }
-
- LayoutRect m_renderedRect;
};
-inline void RenderedDocumentMarker::invalidate(const LayoutRect& r)
-{
- if (m_renderedRect.intersects(r))
- invalidate();
-}
-
DEFINE_TYPE_CASTS(RenderedDocumentMarker, DocumentMarker, marker, true, true);
} // namespace blink
« no previous file with comments | « sky/engine/core/dom/DocumentMarkerController.cpp ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698