Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 830093003: Partially reland Auto-generate v8 version based on tags. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev, Torne
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Partially reland Auto-generate v8 version based on tags. This relands parts of https://codereview.chromium.org/843913009 It prepares for using this script outside of v8, e.g. in a chromium hook. The script is intended to run as a hook and will create version_gen.cc if the content has changed. Changes to gyp and gn files can land as a follow up, once calling the hook on the chromium side has landed. BUG=chromium:446166 LOG=n Committed: https://crrev.com/0707afc863e14ad216fa2157f41fc35f86bd64b2 Cr-Commit-Position: refs/heads/master@{#26144}

Patch Set 1 #

Patch Set 2 : Move script to more general location. #

Patch Set 3 : New approach #

Patch Set 4 : Version creation in toplevel Makefile #

Total comments: 4

Patch Set 5 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -85 lines) Patch
M .gitignore View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Makefile View 1 2 3 4 6 chunks +15 lines, -7 lines 0 comments Download
A build/generate_version.py View 1 2 3 1 chunk +118 lines, -0 lines 0 comments Download
M tools/push-to-trunk/generate_version.py View 1 1 chunk +0 lines, -78 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-19 15:15:23 UTC) #3
Michael Achenbach
CC torne
5 years, 11 months ago (2015-01-19 15:18:45 UTC) #4
Jakob Kummerow
lgtm https://codereview.chromium.org/830093003/diff/80001/Makefile File Makefile (right): https://codereview.chromium.org/830093003/diff/80001/Makefile#newcode285 Makefile:285: version: Please add "version" to the .PHONY list ...
5 years, 11 months ago (2015-01-19 15:26:52 UTC) #5
Michael Achenbach
https://codereview.chromium.org/830093003/diff/80001/Makefile File Makefile (right): https://codereview.chromium.org/830093003/diff/80001/Makefile#newcode285 Makefile:285: version: On 2015/01/19 15:26:52, Jakob wrote: > Please add ...
5 years, 11 months ago (2015-01-19 15:48:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830093003/100001
5 years, 11 months ago (2015-01-19 15:50:26 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 11 months ago (2015-01-19 16:23:30 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 16:23:44 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0707afc863e14ad216fa2157f41fc35f86bd64b2
Cr-Commit-Position: refs/heads/master@{#26144}

Powered by Google App Engine
This is Rietveld 408576698