Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 843913009: Reland Auto-generate v8 version based on tags. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Auto-generate v8 version based on tags. This relands the CL https://codereview.chromium.org/797503007/. It runs the version generation two times. First during runhooks as a fallback for recipes that loose git context (e.g. android_aosp). Second during compilation like in the original CL. In case of failures, the result from the runhooks call will be reused. BUG=chromium:446166 LOG=n Committed: https://crrev.com/d3d6e38b2cba73b52bd5ed00f4441a7db3284a19 Cr-Commit-Position: refs/heads/master@{#26120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -20 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M BUILD.gn View 4 chunks +21 lines, -1 line 0 comments Download
M DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 4 chunks +35 lines, -1 line 0 comments Download
M tools/push-to-trunk/generate_version.py View 3 chunks +74 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-15 13:38:24 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-16 10:46:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843913009/1
5 years, 11 months ago (2015-01-18 10:58:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-18 11:25:49 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d3d6e38b2cba73b52bd5ed00f4441a7db3284a19 Cr-Commit-Position: refs/heads/master@{#26120}
5 years, 11 months ago (2015-01-18 11:26:13 UTC) #7
Michael Achenbach
5 years, 11 months ago (2015-01-18 15:42:09 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/855263002/ by machenbach@chromium.org.

The reason for reverting is: The gclient hook of v8 is not executed on this
builder:

http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu....

Powered by Google App Engine
This is Rietveld 408576698