Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: content/browser/accessibility/browser_accessibility_manager.cc

Issue 830053004: Suppress accessibility events when user is navigating away. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc
index 0bc4260ac629c53f97b73de99dfd7371a88ace76..4ef63cf5c3f168a4e8b5bfe7147a25221db3e47c 100644
--- a/content/browser/accessibility/browser_accessibility_manager.cc
+++ b/content/browser/accessibility/browser_accessibility_manager.cc
@@ -79,6 +79,7 @@ BrowserAccessibilityManager::BrowserAccessibilityManager(
factory_(factory),
tree_(new ui::AXSerializableTree()),
focus_(NULL),
+ user_is_navigating_away_(false),
osk_state_(OSK_ALLOWED) {
tree_->SetDelegate(this);
}
@@ -91,6 +92,7 @@ BrowserAccessibilityManager::BrowserAccessibilityManager(
factory_(factory),
tree_(new ui::AXSerializableTree()),
focus_(NULL),
+ user_is_navigating_away_(false),
osk_state_(OSK_ALLOWED) {
tree_->SetDelegate(this);
Initialize(initial_tree);
@@ -152,6 +154,18 @@ void BrowserAccessibilityManager::OnWindowBlurred() {
NotifyAccessibilityEvent(ui::AX_EVENT_BLUR, GetFromAXNode(focus_));
}
+void BrowserAccessibilityManager::UserIsNavigatingAway(bool is_reload) {
nasko 2015/02/03 17:28:05 This is unused. Why add this parameter now?
dmazzoni 2015/02/03 17:40:54 I added it here to let you know it's something I'd
+ user_is_navigating_away_ = true;
+}
+
+void BrowserAccessibilityManager::NavigationSucceeded() {
+ user_is_navigating_away_ = false;
+}
+
+void BrowserAccessibilityManager::NavigationFailed() {
+ user_is_navigating_away_ = false;
+}
+
void BrowserAccessibilityManager::GotMouseDown() {
osk_state_ = OSK_ALLOWED_WITHIN_FOCUSED_OBJECT;
NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, GetFromAXNode(focus_));

Powered by Google App Engine
This is Rietveld 408576698