Suppress accessibility events when user is navigating away.

content/browser/web_contents/web_contents_impl.cc

Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index a6a7c488357c29203be043f2c9003eb563eb9353..e15b67cd10d93bb665bf318f4b1b871c554fcd34 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2502,6 +2502,11 @@ void WebContentsImpl::DidFailProvisionalLoadWithError(
                                            validated_url,
                                            params.error_code,
                                            params.error_description));
+
+    BrowserAccessibilityManager* manager =

[nasko, 2015/02/03 17:28:05]

nit: wrong indent.

[dmazzoni, 2015/02/04 20:56:06]

Done.

+      render_frame_host->browser_accessibility_manager();
+  if (manager)
+    manager->NavigationFailed();
 }
 
 void WebContentsImpl::DidFailLoadWithError(
@@ -2538,6 +2543,16 @@ void WebContentsImpl::DidStartNavigationToPendingEntry(
       WebContentsObserver,
       observers_,
       DidStartNavigationToPendingEntry(url, reload_type));
+
+  // Notify accessibility that the user is navigating away from the
+  // current RenderFrameHost.
+  FrameTreeNode* ftn = render_frame_host->frame_tree_node();

[dmazzoni, 2015/01/21 18:59:04]

This is the only function that gets called early enough, and has |reload_type| -
but |render_frame_host| is the new RFH, not the "current" one. It'd be nice to
have a notification on the current RFH that it's going to be replaced with
another one.

[nasko, 2015/02/03 17:28:05]

Architecturally, we can't notify before commit time what the new RFH is going to
be. Commit time is too late for you, based on my understanding, otherwise there
is such thing - RenderFrameHostChanged.

[dmazzoni, 2015/02/03 17:40:54]

What I'm observing is that for a browser-initiated navigation,
|render_frame_host| is the *new* RFH. I had to add this code to get the current
frame host from the frame tree node in order to get the *old* RFH, because
that's the one that's currently in the accessibility tree and we want to notify
it that it should enter the "busy" state.

[nasko, 2015/02/03 18:05:18]

What you are observing is correct for this very specific bug you are trying to
fix. If you go to google.com and then type another google.com, you shouldn't be
getting a new RFH different from the current one.

[dmazzoni, 2015/02/03 18:20:27]

That's true.

The point is that I need a notification telling me that a navigation *may* be
happening, and I need to know the current/previous RFH at that time. If the
navigation leads us to the same RFH or a different RFH, or if it fails and we
end up with the original RFH, either way we'll catch that in either
DidCommitProvisionalLoad or DidFailProvisionalLoadWithError.

+  BrowserAccessibilityManager* manager =
+      ftn->current_frame_host()->browser_accessibility_manager();
+  if (manager) {
+    bool is_reload = reload_type != NavigationController::NO_RELOAD;
+    manager->UserIsNavigatingAway(is_reload);
+  }
 }
 
 void WebContentsImpl::RequestOpenURL(RenderFrameHostImpl* render_frame_host,
@@ -2576,6 +2591,11 @@ void WebContentsImpl::DidCommitProvisionalLoad(
                     observers_,
                     DidCommitProvisionalLoadForFrame(
                         render_frame_host, url, transition_type));
+
+  BrowserAccessibilityManager* manager =
+      render_frame_host->browser_accessibility_manager();
+  if (manager)
+    manager->NavigationSucceeded();
 }
 
 void WebContentsImpl::DidNavigateMainFramePreCommit(