Issue 830033003: change API contract: disallow zero-sized images or surfaces

Issue 830033003: change API contract: disallow zero-sized images or surfaces (Closed)

Created:
5 years, 11 months ago by reed2

Modified:
5 years, 11 months ago

Reviewers:
bsalomon, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

change API contract: disallow zero-sized images or surfaces BUG=skia: Committed: https://skia.googlesource.com/skia/+/b2497c2d945c0a5d770865b026e2d5947bf37c91

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -35 lines)			Patch
M	include/core/SkImage.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	include/core/SkSurface.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/image/SkImage_Raster.cpp	View	5 chunks	+3 lines, -29 lines	0 comments	Download
M	src/image/SkSurface.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/image/SkSurface_Raster.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/SurfaceTest.cpp	View	3 chunks	+33 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830033003/1

5 years, 11 months ago (2014-12-31 20:22:08 UTC) #4

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

5 years, 11 months ago (2014-12-31 20:22:08 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2014-12-31 20:31:47 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b2497c2d945c0a5d770865b026e2d5947bf37c91